Dans comments

Author: tejas7777

src/worker/sms.py

@@ -147,6 +147,8 @@ async def _test_send_sms(self, sms_data: SmsData):
 
     async def _messagebird_send_sms(self, sms_data: SmsData):
         send_ts = utcnow()
+        main_logger.info('sending SMS to %s, parts: %d', sms_data.number.number, sms_data.length.parts)
+
         r = await self.messagebird.post(
             'messages',
             originator=self.from_name,

tests/test_sms.py

@@ -222,45 +222,6 @@ def test_send_messagebird(cli, tmpdir, dummy_server, worker, loop):
     assert dummy_server.log[1] == 'POST /messagebird/messages > 201'
 
 
-def test_messagebird_webhook(cli, sync_db: SyncDb, dummy_server, worker, loop):
-    data = {
-        'uid': str(uuid4()),
-        'company_code': 'webhook-test',
-        'method': 'sms-messagebird',
-        'main_template': 'this is a message',
-        'recipients': [{'first_name': 'John', 'last_name': 'Doe', 'user_link': 4321, 'number': '07801234567'}],
-    }
-    r = cli.post('/send/sms/', json=data, headers={'Authorization': 'testing-key'})
-    assert r.status_code == 201, r.text
-    assert worker.test_run() == 1
-
-    msg = sync_db.fetchrow_b('select * from messages join message_groups g on g.id = messages.id')
-    assert msg['status'] == 'send'
-    assert msg['to_first_name'] == 'John'
-    assert msg['to_last_name'] == 'Doe'
-    assert msg['to_user_link'] == '4321'
-    assert msg['to_address'] == '+44 7801 234567'
-    assert msg['from_name'] == 'Morpheus'
-    assert msg['body'] == 'this is a message'
-    assert msg['cost'] is None
-    assert len(msg['tags']) == 1  # just group_id
-
-    url_args = {
-        'id': msg['external_id'],
-        'reference': 'morpheus',
-        'recipient': '447801234567',
-        'status': 'delivered',
-        'statusDatetime': '2032-06-06T12:00:00',
-        'price[amount]': 0.006,
-    }
-    r = cli.get(f'/webhook/messagebird/?{urlencode(url_args)}')
-    assert r.status_code == 200, r.text
-    assert worker.test_run() == 2
-
-    msg = sync_db.fetchrow_b('select * from messages')
-    assert msg['status'] == 'delivered'
-
-
 def test_messagebird_webhook_sms_pricing(cli, sync_db: SyncDb, dummy_server, worker, loop):
     data = {
         'uid': str(uuid4()),
@@ -301,8 +262,6 @@ def test_messagebird_webhook_sms_pricing(cli, sync_db: SyncDb, dummy_server, wor
     assert msg['status'] == 'delivered'
     assert msg['cost'] == 0.07
 
-    #
-
 
 def test_failed_render(cli, tmpdir, sync_db: SyncDb, worker, loop):
     data = {
@@ -402,6 +361,4 @@ def test_sms_billing(cli, send_sms, send_webhook, sync_db):
         '/billing/sms-test/billing-test/', json=dict(uid=str(uuid4()), **data), headers={'Authorization': 'testing-key'}
     )
     assert r.status_code == 200, r.text
-
-    print(r.json())
     assert {'company': 'billing-test', 'start': start, 'end': end, 'spend': 0.048} == r.json()