adding cache_dir to AsyncPydf, removing 3.5 support

Author: samuelcolvin

.travis.yml

@@ -2,7 +2,6 @@ language: python
 sudo: false
 
 python:
-- '3.5'
 - '3.6'
 - 'nightly'
 

HISTORY.rst

@@ -5,4 +5,17 @@ History
 
 v0.31.0 (2017-05-23)
 ....................
-* move to python 3.5 +
+* move to python 3.6 +
+* add ``async`` generation for roughly 10x speedup
+
+v0.30.0
+.......
+
+-  uprev wkhtmltopdf from **0.12.2 (beta)** to **0.12.4**.
+-  code cleanup
+- (this is the same as ``v0.3``, I made a mistake when versioning)
+
+v0.21.0
+.......
+
+- correct permissions on wkhtmltopdf binary.

README.rst

@@ -2,7 +2,7 @@ pydf
 ====
 
 
-|Build Status| |codecov.io| |PyPI Status| |license|
+|BuildStatus| |codecov| |PyPI| |license|
 
 PDF generation in python using
 `wkhtmltopdf <http://wkhtmltopdf.org/>`__.
@@ -94,26 +94,11 @@ option
 Low level function to call wkhtmltopdf, arguments are added to
 wkhtmltopdf binary and passed to subprocess with not processing.
 
-Changelog
----------
-
-0.30
-~~~~
-
--  uprev wkhtmltopdf from **0.12.2 (beta)** to **0.12.4**.
--  code cleanup
-- (this is the same as ``v0.3``, I made a mistake when versioning)
-
-0.21
-~~~~
-
-- correct permissions on wkhtmltopdf binary.
-
-.. |Build Status| image:: https://travis-ci.org/tutorcruncher/pydf.svg?branch=master
+.. |BuildStatus| image:: https://travis-ci.org/tutorcruncher/pydf.svg?branch=master
    :target: https://travis-ci.org/tutorcruncher/pydf
-.. |codecov.io| image:: https://codecov.io/github/tutorcruncher/pydf/coverage.svg?branch=master
+.. |codecov| image:: https://codecov.io/github/tutorcruncher/pydf/coverage.svg?branch=master
    :target: https://codecov.io/github/tutorcruncher/pydf?branch=master
-.. |PyPI Status| image:: https://img.shields.io/pypi/v/python-pdf.svg?style=flat
+.. |PyPI| image:: https://img.shields.io/pypi/v/python-pdf.svg?style=flat
    :target: https://pypi.python.org/pypi/python-pdf
 .. |license| image:: https://img.shields.io/pypi/l/python-pdf.svg
    :target: https://github.com/tutorcruncher/pydf

benchmark/run.py

@@ -16,7 +16,7 @@
 
 
 def go_sync():
-    count = 20
+    count = 10
     for i in range(count):
         pdf = generate_pdf(
             html,
@@ -53,7 +53,6 @@ async def gen(i_):
             zoom='1.25',
             margin_left='8mm',
             margin_right='8mm',
-            cache_dir=PDF_CACHE,
         )
         print(f'{i_:03}: {len(pdf)}')
         file = OUT_DIR / f'output_{i_:03}.pdf'

pydf/wkhtmltopdf.py

@@ -1,6 +1,7 @@
 import asyncio
 import re
 import subprocess
+import tempfile
 
 from pathlib import Path
 
@@ -63,6 +64,10 @@ class AsyncPydf:
     def __init__(self, *, max_processes=20, loop=None):
         self.semaphore = asyncio.Semaphore(value=max_processes, loop=loop)
         self.loop = loop
+        cache_dir = Path(tempfile.gettempdir()) / 'pydf_cache'
+        if not cache_dir.exists():
+            Path.mkdir(cache_dir)
+        self.cache_dir = str(cache_dir)
 
     async def generate_pdf(self,
                            html,
@@ -72,6 +77,7 @@ async def generate_pdf(self,
                            creator=None,
                            producer=None,
                            **cmd_args):
+        cmd_args.setdefault('cache_dir', self.cache_dir)
         cmd_args = [WK_PATH] + _convert_args(cmd_args)
         async with self.semaphore:
             p = await asyncio.create_subprocess_exec(

setup.py

@@ -38,7 +38,6 @@ def run(self):
         'License :: OSI Approved :: MIT License',
         'Programming Language :: Python',
         'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Topic :: Internet :: WWW/HTTP',
         ],