error handling: don't tell user to retry if that won't help

Author: clstaudt

app/auth/intent.py

@@ -174,7 +174,7 @@ def update_user_with_info(
         result = self._data_source.save_user(user)
 
         if not result.was_intent_successful:
-            result.error_msg = "Failed to update your info! Please retry"
+            result.error_msg = "Failed to update your info! "
             result.log_message_if_any()
         return result
 

app/clients/intent.py

@@ -75,7 +75,7 @@ def save_client(
 
         if not result.was_intent_successful:
             result.log_message_if_any()
-            result.error_msg = "Failed to save the client! Please retry"
+            result.error_msg = "Failed to save the client! "
         return result
 
     def get_all_contacts_as_map(self) -> Mapping[int, Contact]:

app/contacts/intent.py

@@ -52,7 +52,7 @@ def get_contact_by_id(self, contact_id) -> IntentResult[Contact]:
         """
         result: IntentResult[Contact] = self._data_source.get_contact_by_id(contact_id)
         if not result.was_intent_successful:
-            result.error_msg = "Retrieving contact failed. Please retry"
+            result.error_msg = "Retrieving contact failed. "
             result.log_message_if_any()
         return result
 
@@ -81,7 +81,7 @@ def save_contact(self, contact: Contact) -> IntentResult[Union[Contact, None]]:
             )
         result = self._data_source.save_contact(contact=contact)
         if not result.was_intent_successful:
-            result.error_msg = "Saving contact failed. Please retry"
+            result.error_msg = "Saving contact failed. "
             result.log_message_if_any()
         return result
 

app/contracts/intent.py

@@ -52,7 +52,7 @@ def get_contract_by_id(self, contractId) -> IntentResult[Optional[Contract]]:
         """
         result = self._data_source.get_contract_by_id(contractId)
         if not result.was_intent_successful:
-            result.error_msg = "Failed to load contract details. Please retry"
+            result.error_msg = "Failed to load contract details. "
             result.log_message_if_any()
         return result
 
@@ -206,7 +206,7 @@ def delete_contract_by_id(self, contract_id: str):
         """Deletes the contract with the given id"""
         result: IntentResult = self._data_source.delete_contract_by_id(contract_id)
         if not result.was_intent_successful:
-            result.error_msg = "Failed to delete that contract! Please retry"
+            result.error_msg = "Failed to delete that contract! "
             result.log_message_if_any()
         return result
 
@@ -217,9 +217,7 @@ def toggle_complete_status(self, contract: Contract) -> IntentResult[Contract]:
         if not result.was_intent_successful:
             # undo the change
             contract.is_completed = not contract.is_completed
-            result.error_msg = (
-                "Failed to update the completed status of the contract. Please retry"
-            )
+            result.error_msg = "Failed to update the completed status of the contract. "
             result.log_message_if_any()
         result.data = contract
         return result

app/invoicing/intent.py

@@ -83,7 +83,7 @@ def delete_invoice_by_id(self, invoice_id) -> IntentResult[None]:
             logger.exception(ex)
             return IntentResult(
                 was_intent_successful=False,
-                message="Could not delete invoice. ",
+                error_msg="Could not delete invoice. ",
             )
 
     def create_invoice(

app/projects/intent.py

@@ -79,7 +79,7 @@ def save_project(
                     if old_project_result.was_intent_successful
                     else None
                 )
-            result.error_msg = "Failed to save the project. Please retry"
+            result.error_msg = "Failed to save the project. "
             result.log_message_if_any()
         return result
 
@@ -170,7 +170,7 @@ def delete_project_by_id(self, project_id: str) -> IntentResult[None]:
         """
         result: IntentResult = self._data_source.delete_project_by_id(project_id)
         if not result.was_intent_successful:
-            result.error_msg = "Failed to delete that project! Please retry"
+            result.error_msg = "Failed to delete that project! "
             result.log_message_if_any()
         return result