Skip to content

Commit b263176

Browse files
committed
cleanup
1 parent 6ca3cb8 commit b263176

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

keyctl/keyctlwrapper.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
# -*- coding: utf-8 -*-
32

43
import subprocess
@@ -51,14 +50,14 @@ class KeyctlWrapper(object):
5150
default_keyring = '@u'
5251
default_keytype = 'user'
5352

54-
def __init__(self, keyring: str=default_keyring, keytype: str=default_keytype):
53+
def __init__(self, keyring: str = default_keyring, keytype: str = default_keytype):
5554
self.keyring = keyring
5655
self.keytype = keytype
5756

5857
# ---------------------------------------------------------------
5958

6059
@staticmethod
61-
def _system(args, data: str=None, check=True):
60+
def _system(args, data: str = None, check=True):
6261

6362
try:
6463
p = subprocess.Popen(
@@ -90,9 +89,7 @@ def _system(args, data: str=None, check=True):
9089

9190
def get_all_key_ids(self) -> List[int]:
9291
out = self._system(['keyctl', 'rlist', self.keyring])
93-
l = out.split()
94-
l = [int(x) for x in l]
95-
return l
92+
return [int(x) for x in out.split()]
9693

9794
# ---------------------------------------------------------------
9895

@@ -183,5 +180,4 @@ def remove_key(self, keyid: int):
183180
def clear_keyring(self):
184181
self._system(['keyctl', 'clear', self.keyring])
185182

186-
187183
# -------------------------------------------------------------------

tests/test_key.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
1-
21
# -*- coding: utf-8 -*-
32

4-
import sys
5-
import os
6-
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
7-
83
import pytest
4+
95
from keyctl import KeyctlWrapper, KeyNotExistError, KeyAlreadyExistError, KeyctlOperationError
106
from keyctl import Key
117

@@ -40,7 +36,7 @@ def test_init(self, empty_keyring):
4036

4137
# non existing key
4238
with pytest.raises(KeyNotExistError):
43-
k = Key(999)
39+
Key(999)
4440

4541
# exisitng key
4642
keyctl = empty_keyring
@@ -80,7 +76,7 @@ def test_list(self, empty_keyring):
8076
def test_search(self, empty_keyring):
8177
# non existing key
8278
with pytest.raises(KeyNotExistError):
83-
k = Key.search('this key does not exist')
79+
Key.search('this key does not exist')
8480

8581
# existing key
8682
keyctl = empty_keyring
@@ -154,5 +150,4 @@ def test_update(self, empty_keyring):
154150
with pytest.raises(KeyNotExistError):
155151
k2.update('xxxx')
156152

157-
158153
# -------------------------------------------------------------------

tests/test_keyctlwrapper.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11

22
# -*- coding: utf-8 -*-
33

4-
import sys
5-
import os
6-
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
7-
84
import pytest
5+
96
from keyctl import KeyctlWrapper, KeyNotExistError, KeyAlreadyExistError
107

118

0 commit comments

Comments
 (0)