net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs

BugLink: https://bugs.launchpad.net/bugs/2097332

[ Upstream commit 9a5beb6 ]

gc->irq_contexts is not freeded if one of the later operations
fail.

Suggested-by: Michael Kelley <[email protected]>
Fixes: 8afefc3 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: Maxim Levitsky <[email protected]>
Reviewed-by: Michal Swiatkowski <[email protected]>
Reviewed-by: Kalesh AP <[email protected]>
Reviewed-by: Saurabh Sengar <[email protected]>
Reviewed-by: Yury Norov <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Koichiro Den <[email protected]>

Author: Maxim Levitsky

drivers/net/ethernet/microsoft/mana/gdma_main.c

@@ -1315,7 +1315,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
 				   GFP_KERNEL);
 	if (!gc->irq_contexts) {
 		err = -ENOMEM;
-		goto free_irq_vector;
+		goto free_irq_array;
 	}
 
 	for (i = 0; i < nvec; i++) {
@@ -1385,8 +1385,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
 	}
 
 	kfree(gc->irq_contexts);
-	kfree(irqs);
 	gc->irq_contexts = NULL;
+free_irq_array:
+	kfree(irqs);
 free_irq_vector:
 	cpus_read_unlock();
 	pci_free_irq_vectors(pdev);