Merge pull request #269 from answerdigital/dependabot/nuget/OmopTransformerTests/MSTest.TestFramework-4.0.1

Bump MSTest.TestFramework from 3.10.4 to 4.0.1

Author: james-cockayne

OmopTransformer/Transformation/Attribute.cs

@@ -12,7 +12,7 @@ private Attribute(object value, ILookup? lookup)
 
     public static Attribute Create(object value)
     {
-        ILookup lookup = null;
+        ILookup? lookup = null;
 
         if (value is TransformAttribute transformAttribute && typeof(ILookup).IsAssignableFrom(transformAttribute.Type))
         {

OmopTransformerTests/OmopTransformerTests.csproj

@@ -19,8 +19,8 @@
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="2025.2.2" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
-    <PackageReference Include="MSTest.TestAdapter" Version="3.10.4" />
-    <PackageReference Include="MSTest.TestFramework" Version="3.10.4" />
+    <PackageReference Include="MSTest.TestAdapter" Version="4.0.1" />
+    <PackageReference Include="MSTest.TestFramework" Version="4.0.1" />
     <PackageReference Include="coverlet.collector" Version="6.0.4" />
     <PackageReference Include="NSubstitute" Version="5.3.0" />
     <PackageReference Include="NUnit" Version="4.4.0" />

OmopTransformerTests/Transformation/StringExtensionsTest.cs

@@ -1,9 +1,9 @@
-using Microsoft.VisualStudio.TestTools.UnitTesting;
 using OmopTransformer;
 
 [TestClass]
 public class StringExtensionsTests
 {
+
     [TestMethod]
     public void SubstringOrNull_ValidInput_ReturnsCorrectSubstring()
     {
@@ -21,17 +21,14 @@ public void SubstringOrNull_WhitespaceOnly_ReturnsNull()
     }
 
     [TestMethod]
-    [ExpectedException(typeof(ArgumentNullException))]
     public void SubstringOrNull_NullInput_ThrowsArgumentNullException()
     {
         string? text = null;
 
-#pragma warning disable CS8604
-        text.SubstringOrNull(0, 1);
-#pragma warning restore CS8604
+        Assert.ThrowsExactly<ArgumentNullException>(() => text!.SubstringOrNull(0, 1));
     }
 
-    [DataTestMethod]
+    [TestMethod]
     [DataRow("", true)]
     [DataRow("   ", true)]
     [DataRow("hello", false)]
@@ -41,7 +38,7 @@ public void IsEmpty_ReturnsExpectedResult(string input, bool expected)
         Assert.AreEqual(expected, input.IsEmpty());
     }
 
-    [DataTestMethod]
+    [TestMethod]
     [DataRow("  test  ", "test")]
     [DataRow(null, null)]
     [DataRow("", "")]
@@ -50,7 +47,7 @@ public void TrimWhitespace_ReturnsExpectedResult(string input, string expected)
         Assert.AreEqual(expected, input.TrimWhitespace());
     }
 
-    [DataTestMethod]
+    [TestMethod]
     [DataRow("hello\r\n", "hello")]
     [DataRow("\r\nhello\r\n", "\r\nhello")]
     [DataRow("hello\r\nworld", "hello\r\nworld")]

OmopTransformerTests/Transformation/TransformationTests.cs

@@ -41,8 +41,8 @@ public void TestTransformation()
             null!)
             .Transform(testConcept, plan);
 
-        Assert.AreEqual(testConcept.Text, "hello world");
-        Assert.AreEqual(testConcept.JoinedText, "line 1\r\nline 2");
+        Assert.AreEqual("hello world", testConcept.Text);
+        Assert.AreEqual("line 1\r\nline 2", testConcept.JoinedText);
         Assert.AreEqual(1, testConcept.ColourId);
         Assert.AreEqual(123, testConcept.ConstantNumber);