refactor: fix review findings from V1.32.0 code review

- analyze: skip zero-size entries in Up/Down navigation so cursor never
  lands on a hidden row
- status: consolidate battery health logic; calculateHealthScore now
  delegates to batteryHealthLabel instead of reimplementing thresholds
- analyze: remove dead "System Caches" case and merge duplicate 💾 arms
  in insightIcon; update test to match
- analyze: remove redundant cacheBreakdownPaths alias, iterate
  cleanablePaths directly
- analyze: simplify measureInsightSize signature to accept path string;
  clean up scanOverviewPathCmd call site
- clean: wrap bun cache-path spinner in TTY guard, consistent with the
  surrounding code

Author: tw93

cmd/analyze/insights.go

@@ -67,8 +67,7 @@ func createInsightEntries() []dirEntry {
 		{"Gradle Cache", filepath.Join(home, ".gradle", "caches")},
 		{"CocoaPods Cache", filepath.Join(home, "Library", "Caches", "CocoaPods")},
 	}
-	cacheBreakdownPaths := cleanablePaths
-	for _, c := range cacheBreakdownPaths {
+	for _, c := range cleanablePaths {
 		if info, err := os.Stat(c.path); err == nil && info.IsDir() {
 			entries = append(entries, dirEntry{
 				Name:  c.name,
@@ -82,18 +81,16 @@ func createInsightEntries() []dirEntry {
 	return entries
 }
 
-// measureInsightSize measures the size of an insight entry.
-// Some insights need special measurement (e.g., Old Downloads only counts old files).
-func measureInsightSize(entry dirEntry) (int64, error) {
+// measureInsightSize measures the size of a path.
+// Old Downloads is treated specially: only files older than 90 days are counted.
+func measureInsightSize(path string) (int64, error) {
 	home := os.Getenv("HOME")
 
-	// Old Downloads: only count files older than 90 days.
-	if home != "" && entry.Path == filepath.Join(home, "Downloads") {
-		return measureOldDownloads(entry.Path, 90)
+	if home != "" && path == filepath.Join(home, "Downloads") {
+		return measureOldDownloads(path, 90)
 	}
 
-	// All others: standard directory size measurement.
-	return measureOverviewSize(entry.Path)
+	return measureOverviewSize(path)
 }
 
 // measureOldDownloads calculates total size of files in a directory
@@ -140,16 +137,14 @@ func insightIcon(entry dirEntry) string {
 		return "📱"
 	case "Old Downloads (90d+)":
 		return "📥"
-	case "System Caches", "Homebrew Cache", "pip Cache", "CocoaPods Cache", "Gradle Cache":
+	case "Homebrew Cache", "pip Cache", "CocoaPods Cache", "Gradle Cache", "Spotify Cache", "JetBrains Cache":
 		return "💾"
 	case "System Logs":
 		return "📋"
 	case "Xcode DerivedData", "Xcode Archives":
 		return "🔨"
 	case "Xcode Simulators":
 		return "📲"
-	case "Spotify Cache", "JetBrains Cache":
-		return "💾"
 	case "Docker Data":
 		return "🐳"
 	default:

cmd/analyze/insights_test.go

@@ -41,7 +41,7 @@ func TestInsightIcon(t *testing.T) {
 	}{
 		{"iOS Backups", "📱"},
 		{"Old Downloads (90d+)", "📥"},
-		{"System Caches", "💾"},
+		{"Homebrew Cache", "💾"},
 		{"System Logs", "📋"},
 		{"Xcode Simulators", "📲"},
 		{"Docker Data", "🐳"},
@@ -99,7 +99,7 @@ func TestMeasureInsightSizeFallsBackToOverview(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	size, err := measureInsightSize(dirEntry{Path: dir})
+	size, err := measureInsightSize(dir)
 	if err != nil {
 		t.Fatalf("measureInsightSize: %v", err)
 	}

cmd/analyze/main.go

@@ -640,7 +640,11 @@ func (m model) updateKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 				}
 			}
 		} else if len(m.entries) > 0 && m.selected > 0 {
-			m.selected--
+			next := m.selected - 1
+			for next > 0 && m.entries[next].Size == 0 {
+				next--
+			}
+			m.selected = next
 			if m.selected < m.offset {
 				m.offset = m.selected
 			}
@@ -655,7 +659,11 @@ func (m model) updateKey(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 				}
 			}
 		} else if len(m.entries) > 0 && m.selected < len(m.entries)-1 {
-			m.selected++
+			next := m.selected + 1
+			for next < len(m.entries)-1 && m.entries[next].Size == 0 {
+				next++
+			}
+			m.selected = next
 			viewport := calculateViewport(m.height, false)
 			if m.selected >= m.offset+viewport {
 				m.offset = m.selected - viewport + 1
@@ -1157,11 +1165,7 @@ func (m *model) removePathFromView(path string) {
 
 func scanOverviewPathCmd(path string, index int) tea.Cmd {
 	return func() tea.Msg {
-		var size int64
-		var err error
-
-		size, err = measureInsightSize(dirEntry{Path: path})
-
+		size, err := measureInsightSize(path)
 		return overviewSizeMsg{
 			Path:  path,
 			Index: index,

cmd/status/metrics_health.go

@@ -138,18 +138,12 @@ func calculateHealthScore(cpu CPUStatus, mem MemoryStatus, disks []DiskStatus, d
 	// Battery health penalty (only when battery present).
 	if len(batteries) > 0 {
 		b := batteries[0]
-		if b.CycleCount > batteryCycleDanger {
+		_, sev := batteryHealthLabel(b.CycleCount, b.Capacity)
+		switch sev {
+		case "danger":
 			score -= 5
-			issues = append(issues, "Battery Aging")
-		} else if b.CycleCount > batteryCycleWarn {
-			score -= 2
-		}
-		if b.Capacity > 0 && b.Capacity < batteryCapDanger {
-			score -= 5
-			if b.CycleCount <= batteryCycleDanger {
-				issues = append(issues, "Battery Degraded")
-			}
-		} else if b.Capacity > 0 && b.Capacity < batteryCapWarn {
+			issues = append(issues, "Battery Service Soon")
+		case "warn":
 			score -= 2
 		}
 	}

lib/clean/dev.sh

@@ -110,9 +110,9 @@ clean_dev_npm() {
             bun_cache_cleaned=true
         fi
 
-        start_section_spinner "Checking bun cache path..."
+        if [[ -t 1 ]]; then start_section_spinner "Checking bun cache path..."; fi
         bun_cache_path=$(run_with_timeout 2 bun pm cache 2> /dev/null) || bun_cache_path=""
-        stop_section_spinner
+        if [[ -t 1 ]]; then stop_section_spinner; fi
 
         if [[ -z "$bun_cache_path" || "$bun_cache_path" != /* ]]; then
             bun_cache_path="$bun_default_cache"