Skip to content

Commit e9f8b8a

Browse files
mdomdo
committed
Address review feedback, restore babelrc, update script tags
1 parent ca81491 commit e9f8b8a

File tree

7 files changed

+26
-14
lines changed

7 files changed

+26
-14
lines changed

‎.babelrc.mjs‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
export default {
2+
presets: [
3+
[
4+
'@babel/preset-env',
5+
{
6+
loose: true,
7+
bugfixes: true,
8+
modules: false
9+
}
10+
]
11+
]
12+
};

‎site/src/components/home/GetStarted.astro‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ import Code from '@shortcodes/Code.astro'
5454
lang="html"
5555
/>
5656
<Code
57-
code={`<script src="${getConfig().cdn.js_bundle}" integrity="${
57+
code={`<script type="module" src="${getConfig().cdn.js_bundle}" integrity="${
5858
getConfig().cdn.js_bundle_hash
5959
}" crossorigin="anonymous"></script>`}
6060
lang="html"

‎site/src/content/docs/customize/color-modes.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Enable the built in dark color mode across your entire project by adding the `da
8080
</head>
8181
<body>
8282
<h1>Hello, world!</h1>
83-
<script src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
83+
<script type="module" src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
8484
</body>
8585
</html>
8686
```

‎site/src/content/docs/getting-started/download.mdx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ Skip the download with [jsDelivr](https://www.jsdelivr.com/) to deliver cached v
3838

3939
```html
4040
<link href="[[config:cdn.css]]" rel="stylesheet" integrity="[[config:cdn.css_hash]]" crossorigin="anonymous">
41-
<script src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
41+
<script type="module" src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
4242
```
4343

4444
If you’re using our compiled JavaScript and prefer to include Floating UI separately, add Floating UI before our JS, via a CDN preferably.
4545

4646
```html
47-
<script src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
48-
<script src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
47+
<script type="module" src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
48+
<script type="module" src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
4949
```
5050

5151
### Alternative CDNs

‎site/src/content/docs/getting-started/install.mdx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ Here are our primary CDN links for CSS and JavaScript:
8080

8181
```html
8282
<link href="[[config:cdn.css]]" rel="stylesheet" integrity="[[config:cdn.css_hash]]" crossorigin="anonymous">
83-
<script src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
83+
<script type="module" src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
8484
```
8585

8686
If you’re using our compiled JavaScript and prefer to include Floating UI separately, add Floating UI before our JS, via a CDN preferably.
8787

8888
```html
89-
<script src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
90-
<script src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
89+
<script type="module" src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
90+
<script type="module" src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
9191
```
9292

9393
<BsTable>

‎site/src/content/docs/getting-started/rtl.mdx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ Here's a modified RTL starter template:
9090
<!-- Optional JavaScript; choose one of the two! -->
9191

9292
<!-- Option 1: Bootstrap Bundle with Floating UI -->
93-
<script src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
93+
<script type="module" src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script>
9494

9595
<!-- Option 2: Separate Floating UI and Bootstrap JS -->
9696
<!--
97-
<script src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
98-
<script src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
97+
<script type="module" src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
98+
<script type="module" src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
9999
-->
100100
</body>
101101
</html>

‎site/src/content/docs/guides/quickstart.mdx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ Get started using Bootstrap in seconds by including our production-ready CSS and
3838
</head>
3939
<body>
4040
<h1>Hello, world!</h1>
41-
<script src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script> // [!code ++]
41+
<script type="module" src="[[config:cdn.js_bundle]]" integrity="[[config:cdn.js_bundle_hash]]" crossorigin="anonymous"></script> // [!code ++]
4242
</body>
4343
</html>
4444
```
4545

4646
You can also include [Floating UI](https://floating-ui.com/) and our JS separately. If you don’t plan to use dropdowns, popovers, or tooltips, save some kilobytes by not including Floating UI.
4747

4848
```html
49-
<script src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
50-
<script src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
49+
<script type="module" src="[[config:cdn.floating_ui]]" integrity="[[config:cdn.floating_ui_hash]]" crossorigin="anonymous"></script>
50+
<script type="module" src="[[config:cdn.js]]" integrity="[[config:cdn.js_hash]]" crossorigin="anonymous"></script>
5151
```
5252

5353
3. **Hello, world!** Open the page in your browser of choice to see your Bootstrapped page. Now you can start building with Bootstrap by creating your own [layout]([[docsref:/layout/grid]]), adding dozens of [components]([[docsref:/components/buttons]]), and utilizing [our official examples]([[docsref:/examples]]).

0 commit comments

Comments
 (0)