Merge pull request #291 from twcclegg/revert

revert all strong name

Author: twcclegg

.github/workflows/build_and_run_unit_tests_linux.yml

@@ -15,9 +15,6 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 9.x
-      - name: Add snk for strong name signing
-        run: |
-          echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
       - name: Add zip files required for running tests
         run: |
           (cd resources/geocoding; zip -r ../../resources/geocoding.zip *)

.github/workflows/codeql.yml

@@ -61,7 +61,6 @@ jobs:
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
       - if: matrix.build-mode == 'manual'
         run: |
-          echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
           (cd resources/geocoding; zip -r ../../resources/geocoding.zip *)
           (cd resources/test/geocoding; zip -r ../../../resources/test/testgeocoding.zip *)
           cd csharp

.github/workflows/create_new_release_on_new_metadata_update.yml

@@ -19,7 +19,6 @@ jobs:
       - name: Get new metadata information and create new GitHub release
         timeout-minutes: 30
         run: |
-          echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
           bash lib/github-actions-metadata-update.sh ${GITHUB_TOKEN}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/run_all_tests_and_upload_code_coverage.yml

@@ -16,10 +16,6 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 9.x
-      - name: Add key.snk for strong name signing
-        run: |
-          echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
-          certutil -decode -f key.snk.b64 key.snk
       - name: Add zip files required for running tests
         run: |
           Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"

.github/workflows/run_performance_tests_windows.yml

@@ -12,10 +12,6 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v4
-      - name: Add key.snk for strong name signing
-        run: |
-          echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
-          certutil -decode -f key.snk.b64 key.snk
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with:

appveyor.yml

@@ -17,16 +17,12 @@ configuration: Release
 environment:
   COVERALLS_REPO_TOKEN:
     secure: vncyomjYijKQKcbLpvs7DFLyNWPjW7tk9KNF/bTV5J/RxOnFydZfsJSsp7SMlvUg
-  KEY_SNK_B64:
-    secure: 4AsBl6Xj6lf78x5EnMNljK0LBxgMuL9CWWDEULg35cv3tJw+xBhOMvyrEsX/ic6gpAZFDk0Oths++CV0wNzwFGGRZqsYcyX5UgQgSYgN2+V/jKwYNWZsafyKyeL9RcSRAkJNv572Dm/nR3AVxg9TSHm4EjTMdLAEZ+BDS8iCnzAcunOgpl2vavrCaQqtP9qAfFUkVLyjvzHzwktEQDyEmJr4sdNLPPg09U+T8C22p2jmQd9sQPGbwZe/ljUbvVYiWY/JfxS7fQQQFgBHSC2Po7IZ3cM4rDmgnmOsRixe1omlV2wwG06Jn3EBsFTgGkQ1AfwxwFgxNZomELRR6N8hHWtnte/SvYR7OD+ZfmdHwRJw3XfmaFgrJ/fhkcjNBRICatVO9kAs9s68A5Jxk0mBH3fCUkl5yvL+ulIXQGzHoBNjILMWDjBwiXJ06qrZzyn5kX/aNIbQt8cP0WEkMYxTvA/+SLL64G6L8Aflx4Sw3LpPq+sADQM1k4xA6ZcziwHCodhJ0d2tqDuKYFmXWf1jNml+jWfFOlGAcDJK592M6Ul3AvbZXRz/CxrKOnQ0WkffxT/79RYWsl3gcpFBmt8eX/Ovsc3ts7AREO3vknXv6fxrwtvQZdRfdV28fGk0rnTu41x/btgBQD9IuqWvnAM2fvyrJ6FMTxVo43u5xwgeakRegovaJkysllslslkhKP/BolPq/nt0OyRwH7QFPUUYZoanT8+kRtxP4BnwZBu/Jr4A4h9W+ryecIVILxt0wZiSQBAS0CYmIdX9f2LZw8A79BydhcrL6EnmNg8JwinTdTLk0q37n4XYehrExm9+x1OqPfErAblSbThHf+ehKaypmPxHdsAP+5HCR7gWdv4E2KuCCkZae3LwjUQhT0r0iMwAfS0nW7MCVo6nUYZtVYxxJB/cvKr/uDzeyezkhOxwOkNP4Nw+NSnZkB1giu0VyoWwKPOHe2Kn+K3ZMWUFNNe5xveY6+SGB6NGU+wYWwqA9eyBmv9YEQl7NNWMVHJtBzp2Q9S/BlShEcv+nB3TqWbPuZE0j6K7qhyVdOw4+HMYZOI=
 pull_requests:
   do_not_increment_build_number: true
 branches:
   only:
     - main
 before_build:
-  - ps: $env:KEY_SNK_B64 | Set-Content -Path "key.snk.b64"
-  - certutil -decode -f key.snk.b64 key.snk
   - dotnet restore csharp -s https://api.nuget.org/v3/index.json
   - ps: Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"
   - ps: Compress-Archive -Path "resources\test\geocoding\*" -DestinationPath "resources\test\testgeocoding.zip"

csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj

@@ -10,15 +10,6 @@
         <IsPackable>false</IsPackable>
     </PropertyGroup>
 
-    <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
-        <SignAssembly>true</SignAssembly>
-        <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
-    </PropertyGroup>
-
-    <PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
-        <PublicSign>true</PublicSign>
-    </PropertyGroup>
-
     <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
       <Nullable>enable</Nullable>
     </PropertyGroup>

csharp/PhoneNumbers.Extensions/PhoneNumbers.Extensions.csproj

@@ -27,15 +27,6 @@
         <AnalysisLevel>5</AnalysisLevel>
     </PropertyGroup>
 
-    <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
-        <SignAssembly>true</SignAssembly>
-        <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
-    </PropertyGroup>
-
-    <PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
-        <PublicSign>true</PublicSign>
-    </PropertyGroup>
-
     <ItemGroup>
         <None Include="..\..\icon.png" Pack="true" PackagePath="" />
     </ItemGroup>

csharp/PhoneNumbers.Test/PhoneNumbers.Test.csproj

@@ -9,15 +9,6 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
-    <PublicSign>true</PublicSign>
-  </PropertyGroup>
-
   <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
     <Nullable>enable</Nullable>
   </PropertyGroup>

csharp/PhoneNumbers/PhoneNumbers.csproj

@@ -29,17 +29,6 @@
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
-    <DefineConstants>$(DefineConstants);SIGNED</DefineConstants>
-  </PropertyGroup>
-
-  <PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
-    <PublicSign>true</PublicSign>
-  </PropertyGroup>
-
-
   <ItemGroup>
     <EmbeddedResource Include="..\..\resources\*.xml" Exclude="..\..\resources\PhoneNumberMetadataForTesting.xml" />
     <EmbeddedResource Include="..\..\resources\timezones\map_data.txt" LinkBase="timezones" />