Skip to content

Commit ba5bc8e

Browse files
authored
Merge pull request #291 from twcclegg/revert
revert all strong name
2 parents 2d3f5fa + 0a4141f commit ba5bc8e

File tree

12 files changed

+1
-61
lines changed

12 files changed

+1
-61
lines changed

.github/workflows/build_and_run_unit_tests_linux.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ jobs:
1515
uses: actions/setup-dotnet@v4
1616
with:
1717
dotnet-version: 9.x
18-
- name: Add snk for strong name signing
19-
run: |
20-
echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
2118
- name: Add zip files required for running tests
2219
run: |
2320
(cd resources/geocoding; zip -r ../../resources/geocoding.zip *)

.github/workflows/codeql.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ jobs:
6161
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
6262
- if: matrix.build-mode == 'manual'
6363
run: |
64-
echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
6564
(cd resources/geocoding; zip -r ../../resources/geocoding.zip *)
6665
(cd resources/test/geocoding; zip -r ../../../resources/test/testgeocoding.zip *)
6766
cd csharp

.github/workflows/create_new_release_on_new_metadata_update.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ jobs:
1919
- name: Get new metadata information and create new GitHub release
2020
timeout-minutes: 30
2121
run: |
22-
echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
2322
bash lib/github-actions-metadata-update.sh ${GITHUB_TOKEN}
2423
env:
2524
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/run_all_tests_and_upload_code_coverage.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ jobs:
1616
uses: actions/setup-dotnet@v4
1717
with:
1818
dotnet-version: 9.x
19-
- name: Add key.snk for strong name signing
20-
run: |
21-
echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
22-
certutil -decode -f key.snk.b64 key.snk
2319
- name: Add zip files required for running tests
2420
run: |
2521
Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"

.github/workflows/run_performance_tests_windows.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ jobs:
1212
timeout-minutes: 20
1313
steps:
1414
- uses: actions/checkout@v4
15-
- name: Add key.snk for strong name signing
16-
run: |
17-
echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
18-
certutil -decode -f key.snk.b64 key.snk
1915
- name: Setup .NET
2016
uses: actions/setup-dotnet@v4
2117
with:

appveyor.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,12 @@ configuration: Release
1717
environment:
1818
COVERALLS_REPO_TOKEN:
1919
secure: vncyomjYijKQKcbLpvs7DFLyNWPjW7tk9KNF/bTV5J/RxOnFydZfsJSsp7SMlvUg
20-
KEY_SNK_B64:
21-
secure: 4AsBl6Xj6lf78x5EnMNljK0LBxgMuL9CWWDEULg35cv3tJw+xBhOMvyrEsX/ic6gpAZFDk0Oths++CV0wNzwFGGRZqsYcyX5UgQgSYgN2+V/jKwYNWZsafyKyeL9RcSRAkJNv572Dm/nR3AVxg9TSHm4EjTMdLAEZ+BDS8iCnzAcunOgpl2vavrCaQqtP9qAfFUkVLyjvzHzwktEQDyEmJr4sdNLPPg09U+T8C22p2jmQd9sQPGbwZe/ljUbvVYiWY/JfxS7fQQQFgBHSC2Po7IZ3cM4rDmgnmOsRixe1omlV2wwG06Jn3EBsFTgGkQ1AfwxwFgxNZomELRR6N8hHWtnte/SvYR7OD+ZfmdHwRJw3XfmaFgrJ/fhkcjNBRICatVO9kAs9s68A5Jxk0mBH3fCUkl5yvL+ulIXQGzHoBNjILMWDjBwiXJ06qrZzyn5kX/aNIbQt8cP0WEkMYxTvA/+SLL64G6L8Aflx4Sw3LpPq+sADQM1k4xA6ZcziwHCodhJ0d2tqDuKYFmXWf1jNml+jWfFOlGAcDJK592M6Ul3AvbZXRz/CxrKOnQ0WkffxT/79RYWsl3gcpFBmt8eX/Ovsc3ts7AREO3vknXv6fxrwtvQZdRfdV28fGk0rnTu41x/btgBQD9IuqWvnAM2fvyrJ6FMTxVo43u5xwgeakRegovaJkysllslslkhKP/BolPq/nt0OyRwH7QFPUUYZoanT8+kRtxP4BnwZBu/Jr4A4h9W+ryecIVILxt0wZiSQBAS0CYmIdX9f2LZw8A79BydhcrL6EnmNg8JwinTdTLk0q37n4XYehrExm9+x1OqPfErAblSbThHf+ehKaypmPxHdsAP+5HCR7gWdv4E2KuCCkZae3LwjUQhT0r0iMwAfS0nW7MCVo6nUYZtVYxxJB/cvKr/uDzeyezkhOxwOkNP4Nw+NSnZkB1giu0VyoWwKPOHe2Kn+K3ZMWUFNNe5xveY6+SGB6NGU+wYWwqA9eyBmv9YEQl7NNWMVHJtBzp2Q9S/BlShEcv+nB3TqWbPuZE0j6K7qhyVdOw4+HMYZOI=
2220
pull_requests:
2321
do_not_increment_build_number: true
2422
branches:
2523
only:
2624
- main
2725
before_build:
28-
- ps: $env:KEY_SNK_B64 | Set-Content -Path "key.snk.b64"
29-
- certutil -decode -f key.snk.b64 key.snk
3026
- dotnet restore csharp -s https://api.nuget.org/v3/index.json
3127
- ps: Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"
3228
- ps: Compress-Archive -Path "resources\test\geocoding\*" -DestinationPath "resources\test\testgeocoding.zip"

csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,6 @@
1010
<IsPackable>false</IsPackable>
1111
</PropertyGroup>
1212

13-
<PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
14-
<SignAssembly>true</SignAssembly>
15-
<AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
16-
</PropertyGroup>
17-
18-
<PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
19-
<PublicSign>true</PublicSign>
20-
</PropertyGroup>
21-
2213
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
2314
<Nullable>enable</Nullable>
2415
</PropertyGroup>

csharp/PhoneNumbers.Extensions/PhoneNumbers.Extensions.csproj

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,6 @@
2727
<AnalysisLevel>5</AnalysisLevel>
2828
</PropertyGroup>
2929

30-
<PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
31-
<SignAssembly>true</SignAssembly>
32-
<AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
33-
</PropertyGroup>
34-
35-
<PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
36-
<PublicSign>true</PublicSign>
37-
</PropertyGroup>
38-
3930
<ItemGroup>
4031
<None Include="..\..\icon.png" Pack="true" PackagePath="" />
4132
</ItemGroup>

csharp/PhoneNumbers.Test/PhoneNumbers.Test.csproj

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,6 @@
99
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1010
</PropertyGroup>
1111

12-
<PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
13-
<SignAssembly>true</SignAssembly>
14-
<AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
15-
</PropertyGroup>
16-
17-
<PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
18-
<PublicSign>true</PublicSign>
19-
</PropertyGroup>
20-
2112
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
2213
<Nullable>enable</Nullable>
2314
</PropertyGroup>

csharp/PhoneNumbers/PhoneNumbers.csproj

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,6 @@
2929
<Nullable>enable</Nullable>
3030
</PropertyGroup>
3131

32-
<PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
33-
<SignAssembly>true</SignAssembly>
34-
<AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
35-
<DefineConstants>$(DefineConstants);SIGNED</DefineConstants>
36-
</PropertyGroup>
37-
38-
<PropertyGroup Condition="'($(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0) And $(APPVEYOR_PULL_REQUEST_NUMBER)'">
39-
<PublicSign>true</PublicSign>
40-
</PropertyGroup>
41-
42-
4332
<ItemGroup>
4433
<EmbeddedResource Include="..\..\resources\*.xml" Exclude="..\..\resources\PhoneNumberMetadataForTesting.xml" />
4534
<EmbeddedResource Include="..\..\resources\timezones\map_data.txt" LinkBase="timezones" />

0 commit comments

Comments
 (0)