Fix name-conventions warnings

Author: avdv

haskell/experimental/private/module.bzl

@@ -140,23 +140,23 @@ def _build_haskell_module(
     """
 
     version = getattr(ctx.attr, "version", None)
-    moduleAttr = module[HaskellModuleInfo].attr
+    module_attr = module[HaskellModuleInfo].attr
 
     # Collect dependencies
-    src = moduleAttr.src.files.to_list()[0]
-    extra_srcs = [f for t in moduleAttr.extra_srcs + ctx.attr.extra_srcs for f in t.files.to_list()]
+    src = module_attr.src.files.to_list()[0]
+    extra_srcs = [f for t in module_attr.extra_srcs + ctx.attr.extra_srcs for f in t.files.to_list()]
 
     user_ghcopts = []
     user_ghcopts += haskell_library_expand_make_variables("ghcopts", ctx, ctx.attr.ghcopts)
 
     module_extra_attrs = [
-        [moduleAttr.src],
-        moduleAttr.extra_srcs,
-        moduleAttr.plugins,
-        moduleAttr.tools,
+        [module_attr.src],
+        module_attr.extra_srcs,
+        module_attr.plugins,
+        module_attr.tools,
     ]
 
-    user_compile_flags = expand_make_variables("ghcopts", ctx, moduleAttr.ghcopts, module_extra_attrs)
+    user_compile_flags = expand_make_variables("ghcopts", ctx, module_attr.ghcopts, module_extra_attrs)
     user_ghcopts += user_compile_flags
 
     import_dir = None
@@ -168,13 +168,13 @@ def _build_haskell_module(
         import_dir = idir
 
     # Note [Plugin order]
-    plugin_decl = reversed(ctx.attr.plugins + moduleAttr.plugins)
+    plugin_decl = reversed(ctx.attr.plugins + module_attr.plugins)
     plugin_dep_info = gather_dep_info(
-        moduleAttr.name,
+        module_attr.name,
         [dep for plugin in plugin_decl for dep in plugin[GhcPluginInfo].deps],
     )
     plugins = [resolve_plugin_tools(ctx, plugin[GhcPluginInfo]) for plugin in plugin_decl]
-    (preprocessors_inputs, preprocessors_input_manifests) = ctx.resolve_tools(tools = ctx.attr.tools + moduleAttr.tools)
+    (preprocessors_inputs, preprocessors_input_manifests) = ctx.resolve_tools(tools = ctx.attr.tools + module_attr.tools)
 
     # TODO[AH] Support additional outputs such as `.hie`.
 
@@ -185,14 +185,14 @@ def _build_haskell_module(
     main_function = getattr(ctx.attr, "main_function", None)
 
     if main_function:
-        if moduleAttr.module_name:
-            guess_module_name = moduleAttr.module_name
+        if module_attr.module_name:
+            guess_module_name = module_attr.module_name
         else:
             guess_module_name = get_module_path_from_target(module).replace("/", ".")
 
         main_file = getattr(ctx.attr, "main_file", None)
         main_function_module = infer_main_module(main_function)
-        if (moduleAttr.src == main_file or main_function_module == guess_module_name):
+        if (module_attr.src == main_file or main_function_module == guess_module_name):
             args.add_all(["-main-is", ctx.attr.main_function])
 
     args.add_all([

haskell/ghc_bindist.bzl

@@ -131,25 +131,25 @@ def _ghc_bindist_impl(ctx):
     # the raw distribution.
     unpack_dir = "bindist_unpacked" if os != "windows" else ""
 
-    stripPrefix = "ghc-" + version
+    strip_prefix = "ghc-" + version
     if GHC_BINDIST_STRIP_PREFIX.get(version) != None and GHC_BINDIST_STRIP_PREFIX[version].get(target) != None:
-        stripPrefix = GHC_BINDIST_STRIP_PREFIX[version][target]
+        strip_prefix = GHC_BINDIST_STRIP_PREFIX[version][target]
     else:
         arch_suffix = {"arm64": "aarch64", "amd64": "x86_64"}.get(arch)
 
         if os == "windows" and version_tuple >= (9, 0, 1):
-            stripPrefix += "-{}-unknown-mingw32".format(arch_suffix)
+            strip_prefix += "-{}-unknown-mingw32".format(arch_suffix)
         elif os == "darwin" and version_tuple >= (9, 0, 2):
-            stripPrefix += "-{}-apple-darwin".format(arch_suffix)
+            strip_prefix += "-{}-apple-darwin".format(arch_suffix)
         elif os == "linux" and version_tuple >= (9, 4, 1):
-            stripPrefix += "-{}-unknown-linux".format(arch_suffix)
+            strip_prefix += "-{}-unknown-linux".format(arch_suffix)
 
     ctx.download_and_extract(
         url = url,
         output = unpack_dir,
         sha256 = sha256,
         type = "tar.xz",
-        stripPrefix = stripPrefix,
+        stripPrefix = strip_prefix,
     )
 
     if os == "windows":

haskell/private/context.bzl

@@ -4,7 +4,7 @@ load("@bazel_skylib//lib:paths.bzl", "paths")
 load("//haskell:providers.bzl", "all_dependencies_package_ids")
 load(":private/path_utils.bzl", "join_path_list")
 
-HaskellContext = provider()
+HaskellContext = provider()  # buildifier: disable=name-conventions
 
 def append_to_path(env, is_windows, path_list):
     if path_list:

haskell/private/haskell_impl.bzl

@@ -752,8 +752,8 @@ def haskell_library_impl(ctx):
 #
 # TODO Get rid of this by computing a CcInfo in haskell_import
 # instead. Currently blocked on upstream.
-HaskellImportHack = provider()
-HaskellToolchainLibraries = provider()
+HaskellImportHack = provider()  # buildifier: disable=name-conventions
+HaskellToolchainLibraries = provider()  # buildifier: disable=name-conventions
 
 def haskell_toolchain_library_impl(ctx):
     hs = haskell_context(ctx)

haskell/repl.bzl

@@ -267,12 +267,12 @@ def _create_HaskellReplCollectInfo(target, dep_labels, dep_package_ids, dep_pack
         java_deps = depset(transitive = java_deps_list)
 
         # TODO[GL]: add tests for CcInfo deps in narrowed_deps
-        ccInfoDeps = [
+        cc_info_deps = [
             dep
             for dep in getattr(ctx.rule.attr, "deps", []) + getattr(ctx.rule.attr, "narrowed_deps", [])
             if CcInfo in dep and not HaskellInfo in dep
         ]
-        ccSharedLibraryInfoDeps = [
+        cc_shared_library_info_deps = [
             dep
             for dep in getattr(ctx.rule.attr, "deps", []) + getattr(ctx.rule.attr, "narrowed_deps", [])
             if CcSharedLibraryInfo in dep and not HaskellInfo in dep
@@ -286,17 +286,17 @@ def _create_HaskellReplCollectInfo(target, dep_labels, dep_package_ids, dep_pack
             boot_files = hs_info.boot_files,
             module_names = hs_info.module_names,
             import_dirs = set.to_depset(hs_info.import_dirs),
-            cc_libraries_info = deps_HaskellCcLibrariesInfo(ccInfoDeps + ccSharedLibraryInfoDeps),
+            cc_libraries_info = deps_HaskellCcLibrariesInfo(cc_info_deps + cc_shared_library_info_deps),
             cc_info = cc_common.merge_cc_infos(cc_infos = [
                 # Collect pure C library dependencies, no Haskell dependencies.
                 dep[CcInfo]
-                for dep in ccInfoDeps
+                for dep in cc_info_deps
             ]),
             cc_shared_library_infos = [merge_cc_shared_library_infos(
                 owner = ctx.label,
                 cc_shared_library_infos = [
                     dep[CcSharedLibraryInfo]
-                    for dep in ccSharedLibraryInfoDeps
+                    for dep in cc_shared_library_info_deps
                 ],
             )],
             compiler_flags = hs_info.user_compile_flags,