Skip to content

Commit 68d9b56

Browse files
committed
Do not invent version number
The version number is optional, the upstream issue was resolved.
1 parent 1e81607 commit 68d9b56

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

haskell/haddock.bzl

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,13 @@ def _haskell_doc_aspect_impl(target, ctx):
8989
html_dir = ctx.actions.declare_directory(html_dir_raw)
9090
haddock_file = ctx.actions.declare_file(_get_haddock_path(package_id))
9191

92-
# XXX Haddock really wants a version number, so invent one from
93-
# thin air. See https://github.com/haskell/haddock/issues/898.
92+
args = ctx.actions.args()
93+
args.add("--package-name={0}".format(package_id))
94+
9495
if target[HaskellLibraryInfo].version:
9596
version = target[HaskellLibraryInfo].version
96-
else:
97-
version = "0"
97+
args.add("--package-version={0}".format(version))
9898

99-
args = ctx.actions.args()
100-
args.add("--package-name={0}".format(package_id))
101-
args.add("--package-version={0}".format(version))
10299
args.add_all([
103100
"-D",
104101
haddock_file.path,

0 commit comments

Comments
 (0)