Merge pull request #2370 from tweag/automation/update-ghc-9.14

* add GHC 9.14 and configure stack snapshots per supported version in start script
* fix problem with newer clang cc toolchain of 9.14.1 on Windows
* use new cabal_flags to toggle haddock generation per cabal (sub-)library

Author: avdv

.github/actions/install_apt_pkgs/action.yaml

@@ -3,8 +3,8 @@ description: Install packages via apt-get install.
 
 inputs:
   packages:
-    type: string
     description: A space-separated list of apt packages to install.
+    required: true
 
 runs:
   using: composite

.github/actions/set_tcp_keepalive_time/action.yaml

@@ -6,7 +6,6 @@ description: Avoids deadline exceeded errors on Linux.
 
 inputs:
   tcp_keepalive_time:
-    type: number
     description: The value to be set for the TCP keep-alive time.
     default: 60
 

.github/workflows/patch-test.yaml

@@ -32,6 +32,14 @@ jobs:
       matrix:
         os: [ubuntu-24.04, macos-14, windows-2022]
         ghc-version: ${{ fromJSON(needs.find-ghc-version.outputs.ghc-matrix) }}
+        exclude:
+          # older GHC versions require the LLVM backend on darwin-arm64,
+          # which does not work out of the box
+          - ghc-version: 8.10.7
+            os: macos-14
+          - ghc-version: 9.0.2
+            os: macos-14
+
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
@@ -68,7 +76,7 @@ jobs:
           packages: libnuma-dev
       - name: Build & test
         shell: bash
-        run: |
-          export GHC_VERSION=${{ matrix.ghc-version }}
-          cd rules_haskell_tests
-          ./tests/run-start-script.sh --use-bindists
+        env:
+          GHC_VERSION: ${{ matrix.ghc-version }} 
+        working-directory: rules_haskell_tests
+        run: ./tests/run-start-script.sh --use-bindists

haskell/cabal.bzl

@@ -431,10 +431,12 @@ def _haskell_cabal_args_impl(ctx):
     is_empty = ctx.attr.is_empty
     ignore_setup = ctx.attr.ignore_setup
     static_binary = ctx.attr.static_binary
+    with_haddock = ctx.attr.with_haddock
     cabal_args = HaskellCabalArgsInfo(
         is_empty = is_empty,
         ignore_setup = ignore_setup,
         static_binary = static_binary,
+        with_haddock = with_haddock,
     )
     return [cabal_args]
 
@@ -456,6 +458,11 @@ haskell_cabal_args = rule(
             defaults to True. Some programs (like haskell-language-server) require dynamic linking
             for certain functionality.""",
         ),
+        "with_haddock": attr.bool(
+            default = True,
+            doc = """Whether to build haddock docs for Haskell modules. Some components do not contain
+            Haskell code and no haddock output will be generated.""",
+        ),
     },
     provides = [HaskellCabalArgsInfo],
 )
@@ -472,9 +479,13 @@ def _haskell_cabal_library_impl(ctx):
 
     is_empty = False
     ignore_setup = False
+    with_haddock = hs.tools_config.supports_haddock
     if ctx.attr.cabal_args:
-        is_empty = ctx.attr.cabal_args[HaskellCabalArgsInfo].is_empty
-        ignore_setup = ctx.attr.cabal_args[HaskellCabalArgsInfo].ignore_setup
+        cabal_args = ctx.attr.cabal_args[HaskellCabalArgsInfo]
+
+        is_empty = cabal_args.is_empty
+        ignore_setup = cabal_args.ignore_setup
+        with_haddock = with_haddock and not is_empty and cabal_args.with_haddock
 
     # All C and Haskell library dependencies.
     cc_info = cc_common.merge_cc_infos(
@@ -516,7 +527,6 @@ def _haskell_cabal_library_impl(ctx):
         "_install/{}_data".format(package_id),
         sibling = cabal,
     )
-    with_haddock = ctx.attr.haddock and hs.tools_config.supports_haddock and not is_empty
     if with_haddock:
         haddock_file = hs.actions.declare_file(
             "_install/{}_haddock/{}.haddock".format(package_id, package_name),
@@ -1195,8 +1205,10 @@ _default_components_args = {
     "fail:lib:fail": "@rules_haskell//haskell/cabal:empty_library",
     "ghc-byteorder:lib:ghc-byteorder": "@rules_haskell//haskell/cabal:empty_library",
     "haskell-gi-overloading:lib:haskell-gi-overloading": "@rules_haskell//haskell/cabal:empty_library",
+    "libyaml-clib:lib:libyaml-clib": "@rules_haskell//haskell/cabal:without_haddock",
     "mtl-compat:lib:mtl-compat": "@rules_haskell//haskell/cabal:empty_library",
     "nats:lib:nats": "@rules_haskell//haskell/cabal:empty_library",
+    "zlib-clib:lib:zlib-clib": "@rules_haskell//haskell/cabal:without_haddock",
 }
 
 def _get_components(components, package):

haskell/cabal/BUILD.bazel

@@ -17,3 +17,9 @@ haskell_cabal_args(
     static_binary = False,
     visibility = ["//visibility:public"],
 )
+
+haskell_cabal_args(
+    name = "without_haddock",
+    visibility = ["//visibility:public"],
+    with_haddock = False,
+)

haskell/cc_toolchain_config.bzl

@@ -85,6 +85,25 @@ def _impl(ctx):
             ),
         ],
     )
+    no_canonical_paths_feature = feature(
+        name = "no_canonical_flags",
+        enabled = True,
+        flag_sets = [
+            flag_set(
+                actions = [
+                    ACTION_NAMES.c_compile,
+                    ACTION_NAMES.cpp_compile,
+                ],
+                flag_groups = [
+                    flag_group(
+                        flags = [
+                            "-no-canonical-prefixes",
+                        ] + ([] if ctx.attr.is_clang else ["-fno-canonical-system-headers"]),
+                    ),
+                ],
+            ),
+        ],
+    )
     return cc_common.create_cc_toolchain_config_info(
         ctx = ctx,
         toolchain_identifier = "ghc_windows_mingw64",
@@ -97,7 +116,7 @@ def _impl(ctx):
         abi_libc_version = "local",
         tool_paths = tool_paths,
         artifact_name_patterns = artifact_name_patterns,
-        features = [default_link_flags_feature],
+        features = [default_link_flags_feature, no_canonical_paths_feature],
     )
 
 cc_toolchain_config = rule(

haskell/private/ghc_bindist_generated.json

@@ -3421,5 +3421,137 @@
                 "variant": "int_native"
             }
         ]
+    },
+    "9.14.1": {
+        "darwin_amd64": [
+            {
+                "dist": "apple",
+                "sha256": "404b2ceacb2b2092a2f1d9e8f551a72d0bf34d897c0c7baf3e79ffec837a0b72",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-apple-darwin.tar.xz"
+            }
+        ],
+        "darwin_arm64": [
+            {
+                "dist": "apple",
+                "sha256": "841591f152085be605616682779341847d24fd56bd6d22ca61bb37ee32b50681",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-aarch64-apple-darwin.tar.xz"
+            }
+        ],
+        "linux_amd64": [
+            {
+                "dist": "alpine3_12",
+                "sha256": "238ff218098949b9c6be2315b4a288fbdd2edd4cd29a1b6e27117b784c23802f",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-alpine3_12-linux-static.tar.xz",
+                "variant": "static"
+            },
+            {
+                "dist": "alpine3_12",
+                "sha256": "bb3055242ffb4187851fcfd3483eec14336093fe319cff9cbc435c24397cad35",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-alpine3_12-linux-static-int_native.tar.xz",
+                "variant": "static-int_native"
+            },
+            {
+                "dist": "alpine3_22",
+                "sha256": "7f082fede580b3c19d6571483993a97ab78c0a121e2200b4247881bb1389dbbe",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-alpine3_22-linux.tar.xz"
+            },
+            {
+                "dist": "deb10",
+                "sha256": "c812cbadc685eba6e92778f9de1ebd0f1ea513cdea42db2d487fbd17e88ca3d1",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-deb10-linux.tar.xz"
+            },
+            {
+                "dist": "deb10",
+                "sha256": "5909ada8e19bf7320fd5b6d4be63fe2d12acc4d1cbfd3eea7bb3c1e83a117825",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-deb10-linux-dwarf.tar.xz",
+                "variant": "dwarf"
+            },
+            {
+                "dist": "deb11",
+                "sha256": "98f42ba5b44e50d680434b9d3c7ad51b257678899cf7f806a0c85cf63b6d1095",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-deb11-linux.tar.xz"
+            },
+            {
+                "dist": "deb12",
+                "sha256": "60f7ab75f28df892729fbaff3a54f58ee3ad7e731929f1b2f3eb0208f73de841",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-deb12-linux.tar.xz"
+            },
+            {
+                "dist": "deb9",
+                "sha256": "4b3afbf7979349efc48ea26810ae747f14b1ea2af954122fc4df0a406a09c68e",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-deb9-linux.tar.xz"
+            },
+            {
+                "dist": "fedora33",
+                "sha256": "b92cd3a35d8b5b83d36ddaf99d7a21907b1e18b32d73bc9457bd2a1029e5c66c",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-fedora33-linux.tar.xz"
+            },
+            {
+                "dist": "fedora33",
+                "sha256": "d8818120db7fad7e07b578854a139de5a67b149c9588db92c4e49a912e9874a8",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-fedora33-linux-dwarf.tar.xz",
+                "variant": "dwarf"
+            },
+            {
+                "dist": "fedora38",
+                "sha256": "cd73823eb6747b16393d802bfb7feacfb0e789a4a6f10b7b5a62c6cdbe806e9e",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-fedora38-linux.tar.xz"
+            },
+            {
+                "dist": "rocky8",
+                "sha256": "f796b25efc1c02f15ab716d69c655b38faab8b398a8d408ba5ff97f41ff2831a",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-rocky8-linux.tar.xz"
+            },
+            {
+                "dist": "ubuntu18_04",
+                "sha256": "0d0897cb7ac4c2502265e44803fc74fb11b0dbfeb6668fc532ddaff304a651a0",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-ubuntu18_04-linux.tar.xz"
+            },
+            {
+                "dist": "ubuntu20_04",
+                "sha256": "b75c349730142b345db459423456fe1e5380ae34211ec49ee86182b8908d6423",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-ubuntu20_04-linux.tar.xz"
+            },
+            {
+                "dist": "ubuntu22_04",
+                "sha256": "29410b9856dcb47fe5038e69478fbcf96137166ced8a789e566440747c2b9393",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-ubuntu22_04-linux.tar.xz"
+            },
+            {
+                "dist": "ubuntu24_04",
+                "sha256": "530f0861d1d7b45476c158a9e68aa89987687aaf9939df7a15995c45726e2344",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-ubuntu24_04-linux.tar.xz"
+            }
+        ],
+        "linux_arm64": [
+            {
+                "dist": "alpine3_22",
+                "sha256": "2bdad0992bad9c37cdba8ee8a5a14690b24c325be507b1ae7464510e5be37818",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-aarch64-alpine3_22-linux.tar.xz"
+            },
+            {
+                "dist": "deb10",
+                "sha256": "526c352cceddbf6c580e17ade7e782e3b21b4182d328b2d454c9f13ca7c08992",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-aarch64-deb10-linux.tar.xz"
+            },
+            {
+                "dist": "deb12",
+                "sha256": "6aa27a377451851c851eefdd869e8f5a9217b02ce66c6ca9b418b72efee28427",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-aarch64-deb12-linux.tar.xz"
+            }
+        ],
+        "windows_amd64": [
+            {
+                "dist": "unknown",
+                "sha256": "4914e262a91a9cb65807ec33b3a2adc884894b1dcc33691d820bb9456f2794ba",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-unknown-mingw32.tar.xz"
+            },
+            {
+                "dist": "unknown",
+                "sha256": "d0c5a0f8b7ab7c07b0ebdc1a1fa1cd141113cf93680a2fc8c5d6cd2b3f4e263c",
+                "url": "https://downloads.haskell.org/~ghc/9.14.1/ghc-9.14.1-x86_64-unknown-mingw32-int_native.tar.xz",
+                "variant": "int_native"
+            }
+        ]
     }
 }

haskell/providers.bzl

@@ -40,6 +40,7 @@ HaskellCabalArgsInfo = provider(
         "is_empty": "True if this (sub) library is empty, with only re-exports, and no source files of its own.",
         "ignore_setup": "True if this package contains a \"Setup.hs\" that isn't a cabal Setup module.",
         "static_binary": "True if this package should build a (haskell) static binary. Default is True.",
+        "with_haddock": "True if haddock docs should be generated.",
     },
 )
 

rules_haskell_tests/tests/haskell_cabal_empty_library/BUILD.bazel

@@ -1,4 +1,3 @@
-load("@rules_cc//cc:defs.bzl", "cc_library")
 load("@rules_haskell//haskell:cabal.bzl",
     "haskell_cabal_args",
     "haskell_cabal_library",

start

@@ -219,8 +219,6 @@ case "${MODE}" in
         ;;
 esac > "${ZLIB_BUILD_FILE}"
 
-WITH_HADDOCK=True
-
 case "$GHC_VERSION" in
     8.10.*)
         SNAPSHOT=lts-18.28
@@ -235,16 +233,16 @@ case "$GHC_VERSION" in
         SNAPSHOT=lts-21.5
         ;;
     9.6.*)
-        SNAPSHOT=lts-22.22
+        SNAPSHOT=lts-22.44
+        ;;
+    9.8.*)
+        SNAPSHOT=lts-23.28
+        ;;
+    9.10.*)
+        SNAPSHOT=lts-24.28
         ;;
     *)
-        # zlib >= 0.7.1.0 depends on zlib-clib on Windows (unless using pkg-config), since zlib-clib is
-        # a C only cabal library that does not produce any haddock this results in an error.
-        # See https://github.com/tweag/rules_haskell/issues/2200
-        case "$( uname )" in
-            WindowsNT | MINGW* | MSYS* ) WITH_HADDOCK=False ;;
-        esac
-        SNAPSHOT=nightly-2024-05-24
+        SNAPSHOT=nightly-2026-01-16
         stderr "warning: unsupported GHC version: ${GHC_VERSION}, using stack resolver ${SNAPSHOT}"
 esac
 
@@ -299,7 +297,6 @@ stack_snapshot(
 
     # disable calling pkg-config
     flags = {"zlib": ["-pkg-config"]},
-    haddock = $WITH_HADDOCK,
 
     # LTS snapshot published for ghc-${GHC_VERSION} (default version used by rules_haskell)
     snapshot = "$SNAPSHOT",