Fixed

Author: lucasbordeau

packages/twenty-front/src/modules/command-menu-item/server-items/hooks/useConvertBackendItemToCommandMenuItemConfig.tsx

@@ -85,9 +85,8 @@ export const useConvertBackendItemToCommandMenuItemConfig = () => {
       }
 
       const isEditModeItem =
-        item.conditionalAvailabilityExpression?.includes(
-          'isPageInEditMode',
-        ) ?? false;
+        item.conditionalAvailabilityExpression?.includes('isPageInEditMode') ??
+        false;
 
       const isPinned =
         item.availabilityType !== CommandMenuItemAvailabilityType.FALLBACK &&

packages/twenty-front/src/modules/object-metadata/utils/filterReadableActiveObjectMetadataItems.ts

@@ -0,0 +1,21 @@
+import { type EnrichedObjectMetadataItem } from '@/object-metadata/types/EnrichedObjectMetadataItem';
+import { type ObjectPermissions } from 'twenty-shared/types';
+import { isDefined } from 'twenty-shared/utils';
+
+export const filterReadableActiveObjectMetadataItems = (
+  objectMetadataItems: EnrichedObjectMetadataItem[],
+  objectPermissionsByObjectMetadataId: Record<
+    string,
+    ObjectPermissions & { objectMetadataId: string }
+  >,
+): EnrichedObjectMetadataItem[] =>
+  objectMetadataItems.filter((objectMetadataItem) => {
+    const objectPermissions =
+      objectPermissionsByObjectMetadataId[objectMetadataItem.id];
+
+    return (
+      isDefined(objectPermissions) &&
+      objectPermissions.canReadObjectRecords &&
+      objectMetadataItem.isActive
+    );
+  });

packages/twenty-front/src/modules/object-record/record-table-widget/components/RecordTableWidgetViewLoadEffect.tsx

@@ -21,15 +21,17 @@ export const RecordTableWidgetViewLoadEffect = ({
   const [
     lastLoadedRecordTableWidgetViewId,
     setLastLoadedRecordTableWidgetViewId,
-  ] = useAtomComponentState(
-    lastLoadedRecordTableWidgetViewIdComponentState,
-  );
+  ] = useAtomComponentState(lastLoadedRecordTableWidgetViewIdComponentState);
 
-  const viewFromViewId = useAtomFamilySelectorValue(viewFromViewIdFamilySelector, {
-    viewId,
-  });
+  const viewFromViewId = useAtomFamilySelectorValue(
+    viewFromViewIdFamilySelector,
+    {
+      viewId,
+    },
+  );
 
-  const viewHasFields = isDefined(viewFromViewId) && viewFromViewId.viewFields.length > 0;
+  const viewHasFields =
+    isDefined(viewFromViewId) && viewFromViewId.viewFields.length > 0;
 
   useEffect(() => {
     if (!isDefined(viewFromViewId)) {

packages/twenty-front/src/modules/object-record/record-table/record-table-body/components/RecordTableBodyLoading.tsx

@@ -49,9 +49,7 @@ export const RecordTableBodyLoading = () => {
               data-testid={`row-id-${rowIndex}`}
               data-selectable-id={`row-id-${rowIndex}`}
             >
-              {!isRecordTableDragColumnHidden && (
-                <RecordTableCellDragAndDrop />
-              )}
+              {!isRecordTableDragColumnHidden && <RecordTableCellDragAndDrop />}
               {!isRecordTableCheckboxColumnHidden && (
                 <RecordTableCellCheckbox />
               )}

packages/twenty-front/src/modules/object-record/record-table/utils/__tests__/getRecordTableCellId.test.ts

@@ -1,4 +1,4 @@
-import { getRecordTableCellId } from '../getRecordTableCellId';
+import { getRecordTableCellId } from '@/object-record/record-table/utils/getRecordTableCellId';
 
 describe('getRecordTableCellId', () => {
   it('returns the correct cell id format', () => {

packages/twenty-front/src/modules/object-record/record-table/utils/__tests__/getRecordTableHtmlId.test.ts

@@ -1,4 +1,4 @@
-import { getRecordTableHtmlId } from '../getRecordTableHtmlId';
+import { getRecordTableHtmlId } from '@/object-record/record-table/utils/getRecordTableHtmlId';
 
 describe('getRecordTableHtmlId', () => {
   it('returns the correct html id format', () => {

packages/twenty-front/src/modules/side-panel/pages/page-layout/components/dropdown-content/ChartDataSourceDropdownContent.tsx

@@ -3,6 +3,7 @@ import { useResetChartDraftFiltersSettings } from '@/side-panel/pages/page-layou
 import { useUpdateCurrentWidgetConfig } from '@/side-panel/pages/page-layout/hooks/useUpdateCurrentWidgetConfig';
 import { useWidgetInEditMode } from '@/side-panel/pages/page-layout/hooks/useWidgetInEditMode';
 import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';
+import { filterReadableActiveObjectMetadataItems } from '@/object-metadata/utils/filterReadableActiveObjectMetadataItems';
 import { useObjectPermissions } from '@/object-record/hooks/useObjectPermissions';
 import { DropdownMenuHeader } from '@/ui/layout/dropdown/components/DropdownMenuHeader/DropdownMenuHeader';
 import { DropdownMenuHeaderLeftComponent } from '@/ui/layout/dropdown/components/DropdownMenuHeader/internal/DropdownMenuHeaderLeftComponent';
@@ -49,17 +50,9 @@ export const ChartDataSourceDropdownContent = () => {
     dropdownId,
   );
 
-  const objectsWithReadAccess = objectMetadataItems.filter(
-    (objectMetadataItem) => {
-      const objectPermissions =
-        objectPermissionsByObjectMetadataId[objectMetadataItem.id];
-
-      return (
-        isDefined(objectPermissions) &&
-        objectPermissions.canReadObjectRecords &&
-        objectMetadataItem.isActive
-      );
-    },
+  const objectsWithReadAccess = filterReadableActiveObjectMetadataItems(
+    objectMetadataItems,
+    objectPermissionsByObjectMetadataId,
   );
 
   const regularObjects = objectsWithReadAccess

packages/twenty-front/src/modules/side-panel/pages/page-layout/components/record-table-settings/RecordTableDataSourceDropdownContent.tsx

@@ -16,6 +16,7 @@ import { SelectableListItem } from '@/ui/layout/selectable-list/components/Selec
 import { selectedItemIdComponentState } from '@/ui/layout/selectable-list/states/selectedItemIdComponentState';
 import { useAvailableComponentInstanceIdOrThrow } from '@/ui/utilities/state/component-state/hooks/useAvailableComponentInstanceIdOrThrow';
 import { useAtomComponentStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentStateValue';
+import { filterReadableActiveObjectMetadataItems } from '@/object-metadata/utils/filterReadableActiveObjectMetadataItems';
 import { t } from '@lingui/core/macro';
 import { useState } from 'react';
 import { isDefined } from 'twenty-shared/utils';
@@ -57,18 +58,14 @@ export const RecordTableDataSourceDropdownContent = () => {
   const { closeDropdown } = useCloseDropdown();
   const { getIcon } = useIcons();
 
-  const objectsWithReadAccess = objectMetadataItems.filter(
-    (objectMetadataItem) => {
-      const objectPermissions =
-        objectPermissionsByObjectMetadataId[objectMetadataItem.id];
-
-      return (
-        isDefined(objectPermissions) &&
-        objectPermissions.canReadObjectRecords &&
-        objectMetadataItem.isActive &&
-        !objectMetadataItem.isSystem
-      );
-    },
+  const readableActiveObjectMetadataItems =
+    filterReadableActiveObjectMetadataItems(
+      objectMetadataItems,
+      objectPermissionsByObjectMetadataId,
+    );
+
+  const objectsWithReadAccess = readableActiveObjectMetadataItems.filter(
+    (objectMetadataItem) => !objectMetadataItem.isSystem,
   );
 
   const sortedObjects = objectsWithReadAccess.sort((first, second) =>