Apply suggestions from code review

mpdude · fabpot · web-flow · commit 675cd42a2fe6 · 2026-02-08T16:39:58.000+01:00
Co-authored-by: Fabien Potencier &lt;fabien@potencier.org&gt;
diff --git a/doc/filters/escape.rst b/doc/filters/escape.rst
@@ -63,7 +63,7 @@ documents:
   aware that in some processing contexts like XML, characters like the colon ``:``
   may have meaning like for XML namespace separation.
 
-.. versionadded:: 3.23
+.. versionadded:: 3.24
 
     The ``html_attr_relaxed`` strategy has been added in 3.23.
 
diff --git a/tests/Runtime/EscaperRuntimeTest.php b/tests/Runtime/EscaperRuntimeTest.php
@@ -353,7 +353,7 @@ public function testHtmlAttributeRelaxedEscapingEscapesOwaspRecommendedRanges()
                 } else {
                     $this->assertNotEquals(
                         $literal,
-                        (new EscaperRuntime())->escape($literal, 'html_attr'),
+                        (new EscaperRuntime())->escape($literal, 'html_attr_relaxed'),
                         "$literal should be escaped!");
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ public function testHtmlAttributeRelaxedEscapingEscapesOwaspRecommendedRanges()`
`353`	`353`	`} else {`
`354`	`354`	`$this->assertNotEquals(`
`355`	`355`	`$literal,`
`356`		`- (new EscaperRuntime())->escape($literal, 'html_attr'),`
	`356`	`+ (new EscaperRuntime())->escape($literal, 'html_attr_relaxed'),`
`357`	`357`	`"$literal should be escaped!");`
`358`	`358`	`}`
`359`	`359`	`}`