Skip to content

Commit 43adad3

Browse files
fifteenhexkuba-moo
authored andcommitted
eth: 8139too: Make 8139TOO_PIO depend on !NO_IOPORT_MAP
When 8139too is probing and 8139TOO_PIO=y it will call pci_iomap_range() and from there __pci_ioport_map() for the PCI IO space. If HAS_IOPORT_MAP=n and NO_GENERIC_PCI_IOPORT_MAP=n, like it is on my m68k config, __pci_ioport_map() becomes NULL, pci_iomap_range() will always fail and the driver will complain it couldn't map the PIO space and return an error. NO_IOPORT_MAP seems to cover the case where what 8139too is trying to do cannot ever work so make 8139TOO_PIO depend on being it false and avoid creating an unusable driver. Signed-off-by: Daniel Palmer <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 2f186dd commit 43adad3

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/realtek

1 file changed

+1
-1
lines changed

drivers/net/ethernet/realtek/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ config 8139TOO
5858
config 8139TOO_PIO
5959
bool "Use PIO instead of MMIO"
6060
default y
61-
depends on 8139TOO
61+
depends on 8139TOO && !NO_IOPORT_MAP
6262
help
6363
This instructs the driver to use programmed I/O ports (PIO) instead
6464
of PCI shared memory (MMIO). This can possibly solve some problems

0 commit comments

Comments
 (0)