Skip to content

Commit 5c9c782

Browse files
idoschPaolo Abeni
authored andcommitted
selftests: traceroute: Reword comment
Both of the addresses are configured as primary addresses, but the kernel is expected to choose 10.0.1.1/24 as the source IP of the ICMP error message since it is on the same subnet as the destination IP of the message (10.0.1.3/24). Reword the comment to reflect that. Reviewed-by: Petr Machata <[email protected]> Signed-off-by: Ido Schimmel <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 47efbac commit 5c9c782

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/testing/selftests/net/traceroute.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,10 @@ run_traceroute6()
203203
# |H1|--------------------------|R1|--------------------------|H2|
204204
# ---- N1 ---- N2 ----
205205
#
206-
# where net.ipv4.icmp_errors_use_inbound_ifaddr is set on R1 and
207-
# 1.0.3.1/24 and 1.0.1.1/24 are respectively R1's primary and secondary
208-
# address on N1.
209-
#
206+
# where net.ipv4.icmp_errors_use_inbound_ifaddr is set on R1 and 1.0.3.1/24 and
207+
# 1.0.1.1/24 are R1's primary addresses on N1. The kernel is expected to prefer
208+
# a source address that is on the same subnet as the destination IP of the ICMP
209+
# error message.
210210

211211
cleanup_traceroute()
212212
{

0 commit comments

Comments
 (0)