Skip to content

Commit c344148

Browse files
laeyraudChun-Kuang Hu
authored andcommitted
drm/mediatek: mtk_hdmi: Fix inverted parameters in some regmap_update_bits calls
In mtk_hdmi driver, a recent change replaced custom register access function calls by regmap ones, but two replacements by regmap_update_bits were done incorrectly, because original offset and mask parameters were inverted, so fix them. Fixes: d6e25b3 ("drm/mediatek: hdmi: Use regmap instead of iomem for main registers") Signed-off-by: Louis-Alexis Eyraud <[email protected]> Reviewed-by: CK Hu <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/ Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 1f40369 commit c344148

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/mediatek/mtk_hdmi.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,8 @@ static inline struct mtk_hdmi *hdmi_ctx_from_bridge(struct drm_bridge *b)
182182

183183
static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black)
184184
{
185-
regmap_update_bits(hdmi->regs, VIDEO_SOURCE_SEL,
186-
VIDEO_CFG_4, black ? GEN_RGB : NORMAL_PATH);
185+
regmap_update_bits(hdmi->regs, VIDEO_CFG_4,
186+
VIDEO_SOURCE_SEL, black ? GEN_RGB : NORMAL_PATH);
187187
}
188188

189189
static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable)
@@ -310,8 +310,8 @@ static void mtk_hdmi_hw_send_info_frame(struct mtk_hdmi *hdmi, u8 *buffer,
310310

311311
static void mtk_hdmi_hw_send_aud_packet(struct mtk_hdmi *hdmi, bool enable)
312312
{
313-
regmap_update_bits(hdmi->regs, AUDIO_PACKET_OFF,
314-
GRL_SHIFT_R2, enable ? 0 : AUDIO_PACKET_OFF);
313+
regmap_update_bits(hdmi->regs, GRL_SHIFT_R2,
314+
AUDIO_PACKET_OFF, enable ? 0 : AUDIO_PACKET_OFF);
315315
}
316316

317317
static void mtk_hdmi_hw_config_sys(struct mtk_hdmi *hdmi)

0 commit comments

Comments
 (0)