Commit fb4ef4a
committed
Revert "drm/prime: Use dma_buf from GEM object instance"
This reverts commit f83a9b8.
The dma_buf field in struct drm_gem_object is not stable over the
object instance's lifetime. The field becomes NULL when user space
releases the final GEM handle on the buffer object. This resulted
in a NULL-pointer deref.
Workarounds in commit 5307dce ("drm/gem: Acquire references on
GEM handles for framebuffers") and commit f6bfc9a ("drm/framebuffer:
Acquire internal references on GEM handles") only solved the problem
partially. They especially don't work for buffer objects without a DRM
framebuffer associated.
Hence, this revert to going back to using .import_attach->dmabuf.
v3:
- cc stable
Signed-off-by: Thomas Zimmermann <[email protected]>
Reviewed-by: Simona Vetter <[email protected]>
Acked-by: Christian König <[email protected]>
Acked-by: Zack Rusin <[email protected]>
Cc: <[email protected]> # v6.15+
Link: https://lore.kernel.org/r/[email protected]1 parent bb7f497 commit fb4ef4a
1 file changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
453 | 453 | | |
454 | 454 | | |
455 | 455 | | |
456 | | - | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
457 | 463 | | |
458 | 464 | | |
459 | 465 | | |
| |||
0 commit comments