Add retry logic to add-participant to mitigate proxy address collisions

Author: cweems

src/@types/types.ts

@@ -24,7 +24,7 @@ export interface ActiveProxyAddresses {
 }
 
 export interface ProxyBindings {
-  [key: string]: string;
+  [key: string]: Array<string>;
 }
 
 export interface ConversationParticipant {

src/services/session.service.ts

@@ -36,10 +36,10 @@ export const matchAvailableProxyAddresses = async (activeProxyAddresses: ActiveP
       })
 
       if (availableNumbers.length < 1) {
-        throw new Error('Not enough numbers available in pool.')
+        throw new Error(`Not enough numbers available in pool for ${key}`)
       }
 
-      proxyBindings[key] = availableNumbers[0];
+      proxyBindings[key] = availableNumbers;
     }
 
     return proxyBindings;
@@ -49,18 +49,42 @@ export const matchAvailableProxyAddresses = async (activeProxyAddresses: ActiveP
   }
 }
 
+const retryParticipantAdd = async (conversationSid: string, participantAddress: string, proxyAddresses: Array<string>) => {
+  try {
+    while(proxyAddresses.length > 0) {
+      try {
+        const participant = {
+          'messagingBinding.address': participantAddress,
+          'messagingBinding.proxyAddress': proxyAddresses[0]
+        } as any
+  
+        return addParticipant(conversationSid, participant)
+  
+      } catch(err) {
+        if (err.code === 50416) {
+          const remainingProxyAddresses = proxyAddresses.shift()
+          retryParticipantAdd(conversationSid, participantAddress, remainingProxyAddresses as any)
+        }
+        console.log(err)
+        throw new Error(err)
+      }
+    }
+
+    throw new Error(`No proxy addresses available for ${participantAddress}`)
+  } catch(err) {
+    console.log(err)
+    throw new Error(err)
+  }
+}
+
 export const addParticipantsToConversation = async (conversationSid: string, proxyBindings: ProxyBindings) => {
   const promises = []
 
-  for (const [key, value] of Object.entries(proxyBindings)) {
-    const participant = {
-      'messagingBinding.address': key,
-      'messagingBinding.proxyAddress': value
-    } as any
+  for (const [participantAddress, proxyAddresses] of Object.entries(proxyBindings)) {
 
     try {
-      const participantRequest = addParticipant(conversationSid, participant)
-      promises.push(participantRequest)
+      const participantAttempt = retryParticipantAdd(conversationSid, participantAddress, proxyAddresses)
+      promises.push(participantAttempt)
     } catch (err) {
       console.log(err)
       throw new Error(err)

src/utils/addParticipant.util.ts

@@ -12,7 +12,7 @@ export const addParticipant = async (
         .conversations(conversationSid)
         .participants
         .create(participant)
-      console.log({createdParticipant})
+
       return createdParticipant
     } catch (err) {
       console.log('Create participant err', err);

src/utils/deleteConversation.util.ts

@@ -3,7 +3,6 @@ import client from "../twilioClient"
 import retry from 'async-retry'
 
 export const deleteConversation = async (conversationSid: string) : Promise<boolean> => {
-  console.log('Before retry')
   return retry(async() => {
     try {
       await client.conversations.conversations(conversationSid).remove()

src/utils/listParticipantConversations.util.ts

@@ -3,11 +3,14 @@ import { ParticipantConversationInstance } from 'twilio/lib/rest/conversations/v
 import client from '../twilioClient'
 
 export const listParticipantConversations = async (phoneNumber: string) : Promise<ParticipantConversationInstance[]> => {
-  try {
-    const activeConversations = await client.conversations.participantConversations.list({address: phoneNumber})
-    return activeConversations
-  } catch (err) {
-    console.log(phoneNumber, err)
-    throw new Error(err)
-  }
+  return retry(async () => {
+    try {
+      const activeConversations = await client.conversations.participantConversations.list({address: phoneNumber})
+      return activeConversations
+    } catch (err) {
+      console.log(phoneNumber, err)
+      throw new Error(err)
+    }
+  })
+
 }