Finish addParticipant tests

Author: cweems

src/utils/addParticipant.util.ts

@@ -1,10 +1,12 @@
 import retry from 'async-retry';
 import client from "../twilioClient";
 import { ParticipantInstance, ParticipantListInstanceCreateOptions } from "twilio/lib/rest/conversations/v1/conversation/participant";
+import { retryConfig } from '../config/retry.config';
 
 export const addParticipant = async (
   conversationSid: string,
-  participant: ParticipantListInstanceCreateOptions
+  participant: ParticipantListInstanceCreateOptions,
+  retryOptions = retryConfig
 ) : Promise<ParticipantInstance> => {
   return retry(async (quit) => {
     try {
@@ -16,12 +18,13 @@ export const addParticipant = async (
       return createdParticipant
     } catch (err) {
       if (err.status !== 429) {
+        console.log('Quit without retry')
         quit(new Error(err));
         return;
       }
 
       console.log('Re-trying on 429 error');
       throw new Error(err);
     }
-  })
+  }, retryOptions)
 }

tests/utils/addParticipant.test.ts

@@ -19,10 +19,11 @@ describe('addParticipant util', () => {
 
   it('it adds participant to conversation', async () => {
     let createSpy = jest.fn((options) => { return mockParticipant })
-
-    let participantsSpy = { participants: { create: createSpy } } ;
-    
-    const conversationsSpy = jest.fn((options) => { return participantsSpy });
+    const conversationsSpy = jest.fn((options) => {
+      return {
+        participants: { create: createSpy }
+      }
+    });
 
     mockedClient['conversations'] = {
         conversations: conversationsSpy
@@ -35,5 +36,58 @@ describe('addParticipant util', () => {
     expect(result).not.toBeNull();
   })
 
+  it('calls quit if error is not a 429 retry', async () => {
+    let createSpy = jest.fn((options) => { throw new Error('Twilio Problem') })
+    const conversationsSpy = jest.fn((options) => {
+      return {
+        participants: { create: createSpy }
+      }
+    });
+
+    mockedClient['conversations'] = {
+        conversations: conversationsSpy
+    } as any
+
+    const consoleSpy = jest.spyOn(console, 'log');
+
+    try {
+      await addParticipant("myConversationSid", mockParticipant );
+    } catch (e) {
+      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+    }
+  })
+
+  it('throws error to retry on 429 status code', async () => {
 
+    interface TwilioError extends Error {
+      status: number
+    }
+
+    class TwilioError extends Error {
+      constructor(message) {
+        super(message);
+        this.name = "ConcurrencyLimit";
+        this.status = 429
+      }
+    }
+
+    let createSpy = jest.fn((options) => { throw new TwilioError('Concurrency Limit') })
+    const conversationsSpy = jest.fn((options) => {
+      return {
+        participants: { create: createSpy }
+      }
+    });
+
+    mockedClient['conversations'] = {
+        conversations: conversationsSpy
+    } as any
+
+    const consoleSpy = jest.spyOn(console, 'log');
+
+    try {
+      await addParticipant("myConversationSid", mockParticipant, { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
+    } catch (e) {
+      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+    }
+  })
 })