Skip to content

Commit 4abcf39

Browse files
committed
Added a default closed timer in env and more error handling of defaults
1 parent a43978f commit 4abcf39

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.env.template

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@ OUT_OF_SESSION_MESSAGE_FOR_CALL=
77
CONNECTING_CALL_ANNOUCEMENT=
88
CALL_ANNOUCEMENT_LANGUAGE="en"
99
CALL_ANNOUCEMENT_VOICE="alice"
10-
CONVERSATION_SESSION_TIMEOUT=
10+
CONVERSATION_SESSION_TIMEOUT_IN_MINUTES=
11+
CONVERSATION_SESSION_CLOSED_IN_MINUTES=

routes/proxypoc.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,15 +427,16 @@ router.post('/sessions', async function(req, res, next) {
427427
console.time('sessionCreate');
428428

429429
// use default inactive timer value if none passed
430-
const inactiveTimer = req.body["timers.inactive"] ? req.body["timers.inactive"] : 'PT'+eval(process.env.CONVERSATION_SESSION_TIMEOUT)+'M';
430+
const inactiveTimer = req.body["timers.inactive"] ? req.body["timers.inactive"] : (process.env.CONVERSATION_SESSION_TIMEOUT_IN_MINUTES)?'PT'+eval(process.env.CONVERSATION_SESSION_TIMEOUT_IN_MINUTES)+'M':'PT0M';
431+
const closedTimer = req.body["timers.closed"] ? req.body["timers.closed"] : (process.env.CONVERSATION_SESSION_CLOSED_IN_MINUTES) ? 'PT'+eval(process.env.CONVERSATION_SESSION_CLOSED_IN_MINUTES)+'M':'PT0M';
431432

432433
const sessionOpts = {
433434
attributes: req.body.attributes,
434435
friendlyName: req.body.friendlyName,
435436
messagingServiceSid: req.body.messagingServiceSid,
436437
timers: {
437438
inactive: inactiveTimer,
438-
closed: req.body["timers.closed"],
439+
closed: closedTimer,
439440
},
440441
uniqueName: req.body.uniqueName,
441442
xTwilioWebhookEnabled: req.body.xTwilioWebhookEnabled,

0 commit comments

Comments
 (0)