Add conversation create test for non-429 error

Author: cweems

src/utils/createConversation.util.ts

@@ -8,10 +8,10 @@ export const createConversation = async (options: SessionPostBody) : Promise<Con
 
   return retry(async (quit) => {
     try {
-      const conversation = await client.conversations.conversations.create(options);
-      return conversation;
+      return client.conversations.conversations.create(options);
     } catch (err) {
       if (err.status !== 429) {
+        console.log('Quit without retry')
         console.log(err)
         quit(new Error('Quit without retry'));
         return;

tests/utils/createConversation.test.ts

@@ -10,19 +10,34 @@ describe('createConversation util', () => {
   })
 
   it('it creates conversation with options passed', async () => {
-    const createSpy = jest.fn((options) => {})
+    const createSpy = jest.fn((options) => { return options })
     mockedClient['conversations'] = {
       conversations: {
         create: (options) => createSpy(options)
       }
     } as any
 
-    createConversation({ friendlyName: "my conversation", addresses: ['1', '2'] })
+    const result = await createConversation({ friendlyName: "my conversation", addresses: ['1', '2'] })
 
     expect(createSpy).toBeCalledWith({ friendlyName: "my conversation", addresses: ['1', '2'] })
+    expect(result).toEqual({ friendlyName: "my conversation", addresses: ['1', '2'] })
   })
 
   it('calls quit if error is not a 429 retry', async () => {
-    
+    mockedClient['conversations'] = {
+      conversations: {
+        create: (options) => {
+          throw new Error('Twilio Problem') 
+        }
+      }
+    } as any
+
+    const consoleSpy = jest.spyOn(console, 'log');
+
+    try {
+      await createConversation({ friendlyName: "my conversation", addresses: ['1', '2'] });
+    } catch (e) {
+      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+    }
   })
 })