Removed joinConference controlller

Author: kuschanton

src/@types/types.ts

@@ -32,12 +32,6 @@ export interface ConversationParticipant {
   'messagingBinding.proxyAddress': string;
 }
 
-export interface JoinConferenceParams extends Request {
-  params: {
-    conferenceName: string
-  }
-}
-
 export interface ParticipantToDial {
   address: string,
   proxyAddress: string

src/controllers/index.ts

@@ -1,4 +1,3 @@
 export * as conversationsPostEvent from './conversationsPostEvent'
 export * as inboundCall from './inboundCall'
 export * as session from './session'
-export * as joinConference from './joinConference'

src/controllers/joinConference.ts

@@ -12,7 +12,6 @@ const router = Router()
 router.post('/conversations-post-event', twilio.webhook(webhookConfig), controllers.conversationsPostEvent.post)
 
 router.post('/inbound-call', twilio.webhook(webhookConfig), controllers.inboundCall.post)
-router.post('/join-conference', twilio.webhook(webhookConfig), controllers.joinConference.get)
 
 router.post('/sessions', basicAuth({
   users: { [AUTH_USERNAME]: AUTH_PASSWORD }

src/routes/index.ts

@@ -8,6 +8,14 @@ import {
   generateConferenceName
 } from '../utils/'
 
+export function joinConferenceTwiml (conferenceName: string) : VoiceResponse {
+  const response = new VoiceResponse()
+  const dial = response.dial();
+  dial.conference(`${decodeURIComponent(conferenceName)}`);
+
+  return response
+}
+
 export const generateTwiml = async (from: string, to: string) => {
   const response = new VoiceResponse()
 
@@ -34,12 +42,13 @@ export const generateTwiml = async (from: string, to: string) => {
       const callPromises = dialList.map(pa => {
         console.log(`Dialing ${pa.address} from ${pa.proxyAddress}...`)
 
-        return client.calls.create({
-          url: `https://${process.env.DOMAIN}/join-conference?conferenceName=${encodeURIComponent(conferenceName)}`,
-          to: pa.address,
-          from: pa.proxyAddress
-        })
-      })
+          return client.calls.create({
+              url: `https://${process.env.DOMAIN}/join-conference?conferenceName=${encodeURIComponent(conferenceName)}`,
+              to: pa.address,
+              from: pa.proxyAddress,
+              twiml: joinConferenceTwiml(conferenceName).toString(),
+          });
+      });
 
       await Promise.all(callPromises)