Merge pull request #14 from twilio-labs/controllers-tests-post-event-and-inbound-call-3

Controllers tests post event and inbound call

Author: cweems

src/controllers/conversationsPostEvent.ts

@@ -15,10 +15,10 @@ export const post = async (
   if (eventType === 'onConversationUpdated' && state === 'closed') {
     try {
       await deleteConversation(conversationSid)
+      return res.status(200).send(`${conversationSid} deleted`)
     } catch (err) {
       return res.status(500).send(`${conversationSid} failed to delete: ${err}`)
     }
-    return res.status(200).send(`${conversationSid} deleted`)
   }
   return res.status(200).send('not processed')
 }

tests/controllers/conversationsPostEvent.test.ts

@@ -0,0 +1,96 @@
+import request from 'supertest'
+import {app} from '../../src/app/app'
+import * as DeleteConversation from '../../src/utils/deleteConversation.util'
+
+describe('conversations post event controller', () => {
+  jest.setTimeout(60000)
+
+  beforeEach(() => {
+    jest.resetAllMocks()
+  })
+
+  // Test parameters
+  const eventTypeOnConversationUpdated = 'onConversationUpdated'
+  const eventTypeOther = 'otherEvent123'
+  const closedState = 'closed'
+  const otherState = 'state123'
+  const conversationSid = 'CHXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX'
+
+  it('should delete conversation', async () => {
+    const deleteConversationSpy = jest
+      .spyOn(DeleteConversation, 'deleteConversation')
+      .mockResolvedValue(true)
+
+    const res = await request(app)
+      .post('/conversations-post-event')
+      .set('content-type', 'application/json')
+      .send({
+        EventType: eventTypeOnConversationUpdated,
+        State: closedState,
+        ConversationSid: conversationSid,
+      })
+
+    expect(res.status).toEqual(200)
+    expect(res.text).toEqual(`${conversationSid} deleted`)
+    expect(deleteConversationSpy).toBeCalledWith(conversationSid)
+  })
+
+  it('should ignore if status != closed', async () => {
+    const deleteConversationSpy = jest
+      .spyOn(DeleteConversation, 'deleteConversation')
+      .mockResolvedValue(true)
+
+    const res = await request(app)
+      .post('/conversations-post-event')
+      .set('content-type', 'application/json')
+      .send({
+        EventType: eventTypeOnConversationUpdated,
+        State: otherState,
+        ConversationSid: conversationSid,
+      })
+
+    expect(res.status).toEqual(200)
+    expect(res.text).toEqual('not processed')
+    expect(deleteConversationSpy).toBeCalledTimes(0)
+  })
+
+  it('should ignore if eventType != onConversationUpdated', async () => {
+    const deleteConversationSpy = jest
+      .spyOn(DeleteConversation, 'deleteConversation')
+      .mockResolvedValue(true)
+
+    const res = await request(app)
+      .post('/conversations-post-event')
+      .set('content-type', 'application/json')
+      .send({
+        EventType: eventTypeOther,
+        State: closedState,
+        ConversationSid: conversationSid,
+      })
+
+    expect(res.status).toEqual(200)
+    expect(res.text).toEqual('not processed')
+    expect(deleteConversationSpy).toBeCalledTimes(0)
+  })
+
+  it('should return 500 if throws', async () => {
+    const errorCode = 'ErrorCode123'
+
+    const deleteConversationSpy = jest
+      .spyOn(DeleteConversation, 'deleteConversation')
+      .mockRejectedValue(new Error(errorCode))
+
+    const res = await request(app)
+      .post('/conversations-post-event')
+      .set('content-type', 'application/json')
+      .send({
+        EventType: eventTypeOnConversationUpdated,
+        State: closedState,
+        ConversationSid: conversationSid,
+      })
+
+    expect(res.status).toEqual(500)
+    expect(res.text).toEqual(`${conversationSid} failed to delete: Error: ${errorCode}`)
+    expect(deleteConversationSpy).toBeCalledWith(conversationSid)
+  })
+})

tests/controllers/inboundCall.test.ts

@@ -0,0 +1,34 @@
+import request from 'supertest'
+import * as InboundCallService from '../../src/services/inboundCall.service'
+import { app } from '../../src/app/app'
+import VoiceResponse from 'twilio/lib/twiml/VoiceResponse'
+
+describe('inbound call controller', () => {
+  jest.setTimeout(60000)
+
+  // Test parameters
+  const fromNumber = '+1001'
+  const toNumber = '+1002'
+  const twimlResponse = new VoiceResponse()
+  const dial = twimlResponse.dial();
+  dial.conference('Room1234');
+
+  it('should generate twiml', async () => {
+    const generateTwimlSpy = jest
+      .spyOn(InboundCallService, 'generateTwiml')
+      .mockResolvedValue(twimlResponse)
+
+    const res = await request(app)
+      .post('/inbound-call')
+      .set('content-type', 'application/json')
+      // .set('Authorization', process.env.AUTH_HEADER)
+      .send({
+        From: fromNumber,
+        Called: toNumber
+      })
+
+    expect(res.status).toEqual(200)
+    expect(res.text).toEqual('<?xml version="1.0" encoding="UTF-8"?><Response><Dial><Conference>Room1234</Conference></Dial></Response>')
+    expect(generateTwimlSpy).toBeCalledWith(fromNumber, toNumber)
+  })
+})