PR Feedback

Author: cweems

tests/utils/addParticipant.test.ts

@@ -1,7 +1,7 @@
 import { addParticipant } from "../../src/utils";
 import client from '../../src/twilioClient';
 
-import { ParticipantInstance, ParticipantListInstanceCreateOptions } from "twilio/lib/rest/conversations/v1/conversation/participant";
+import { ParticipantListInstanceCreateOptions } from "twilio/lib/rest/conversations/v1/conversation/participant";
 
 
 jest.mock('../../src/twilioClient')
@@ -53,8 +53,9 @@ describe('addParticipant util', () => {
     try {
       await addParticipant("myConversationSid", mockParticipant );
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+      console.log(e)
     }
+    expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
   })
 
   it('throws error to retry on 429 status code', async () => {
@@ -87,7 +88,9 @@ describe('addParticipant util', () => {
     try {
       await addParticipant("myConversationSid", mockParticipant, { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+      console.log(e);
     }
+
+    expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
   })
 })

tests/utils/createConversation.test.ts

@@ -37,8 +37,10 @@ describe('createConversation util', () => {
     try {
       await createConversation({ friendlyName: "my conversation", addresses: ['1', '2'] });
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+      console.log(e)
     }
+    
+    expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
   })
 
   it('throws error to retry on 429 status code', async () => {
@@ -70,7 +72,9 @@ describe('createConversation util', () => {
         { friendlyName: "my conversation", addresses: ['1', '2']},
         { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+      console.log(e)
     }
+
+    expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
   })
 })

tests/utils/deleteConversation.test.ts

@@ -55,8 +55,10 @@ describe('deleteConversation util', () => {
     try {
       await deleteConversation("myConversationSid");
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+      console.log(e)
     }
+
+    expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
   })
 
   it('retrys if error is 429', async () => {
@@ -93,7 +95,9 @@ describe('deleteConversation util', () => {
     try {
       await deleteConversation("myConversationSid",  { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+      console.log(e)
     }
+    
+    expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
   })
 })

tests/utils/getConversationByAddressPair.test.ts

@@ -57,7 +57,7 @@ describe('GetConversationByAddressPair util', () => {
 
     await expect(getConversationByAddressPair("bad input", "worse input"))
       .rejects
-      .toThrowError('Twilio Proble')
+      .toThrowError('Error: Twilio Problem')
   })
 
   it("should retry if Twilio error is 429", async () => {
@@ -89,8 +89,10 @@ describe('GetConversationByAddressPair util', () => {
       try {
         await getConversationByAddressPair("+1234", "+5678", { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
       } catch (e) {
-        expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+        console.log(e)
       }
+
+      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
   })
 })
 

tests/utils/listConversationParticipants.test.ts

@@ -44,7 +44,7 @@ describe('listConversationParticipants', () => {
 
     await expect(listConversationParticipants("CH123"))
       .rejects
-      .toThrowError('Participant List Erro')
+      .toThrowError('Participant List Error')
   })
 
   it('should retry if Twilio client throws a 429 error', async () => {
@@ -78,8 +78,10 @@ describe('listConversationParticipants', () => {
 
     try {
       await listConversationParticipants("CH123", { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 })
-    } catch(err) {
-      expect(consoleSpy).toBeCalledWith('Re-trying on 429 error')
+    } catch(e) {
+      console.log(e)
     }
+
+    expect(consoleSpy).toBeCalledWith('Re-trying on 429 error')
   })
 })

tests/utils/listParticipantConversations.test.ts

@@ -1,6 +1,5 @@
 import { listParticipantConversations } from "../../src/utils";
 import client from '../../src/twilioClient';
-import { ParticipantConversationInstance } from 'twilio/lib/rest/conversations/v1/participantConversation'
 
 jest.mock('../../src/twilioClient')
 let mockedClient = jest.mocked(client, true)
@@ -39,8 +38,10 @@ describe('ListParticipantConversations util', () => {
     try {
       await listParticipantConversations("+1234");
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
+      console.log(e)
     }
+
+    expect(consoleSpy).toHaveBeenCalledWith('Quit without retry');
   })
 
 
@@ -73,8 +74,10 @@ describe('ListParticipantConversations util', () => {
         "+1234",
         { retries: 0, factor: 1, maxTimeout: 0, minTimeout: 0 });
     } catch (e) {
-      expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
+      console.log(e)
     }
+
+    expect(consoleSpy).toHaveBeenCalledWith('Re-trying on 429 error');
   })
 
 })

tests/utils/retryAddParticipant.test.ts

@@ -34,7 +34,6 @@ describe('retryParticipantAdd', () => {
     mockAddParticipant
       .mockRejectedValueOnce(rejectedValue)
       .mockResolvedValueOnce(mockParticpantInstance as any)
-      // .mockResolvedValueOnce(mockParticpantInstance as any)
 
     const result = await retry.retryAddParticipant('CH1234', '+111', ['+222', '+333'])
     expect(retrySpy).toBeCalledTimes(1)