getActiveProxyAddresses ignores closed conversations

Author: aymenn

src/services/session.service.ts

@@ -5,9 +5,16 @@ export const getActiveProxyAddresses = async (phoneNumbers: Array<String>) : Pro
   const activeConversations = {}
 
   const promises = phoneNumbers.map(async (phoneNumber: string) => {
+    // listParticipantConversations returns ALL conversations, closed and active.
     const participantConversations = await listParticipantConversations(phoneNumber)
 
-    const proxyAddresses = participantConversations.map((participant) => {
+    // We want to ignore closed conversations since we cant use conversations once they're closed.
+    // We can use conversations that are active or inactive
+    const participantActiveConversations = participantConversations.filter((participant) => {
+      return participant.conversationState !== 'closed'
+    })
+    // Let's get all the proxy addresses that currently being used in the active conversations
+    const proxyAddresses = participantActiveConversations.map((participant) => {
       return participant.participantMessagingBinding.proxy_address
     })
 

tests/services/session.test.ts

@@ -20,7 +20,7 @@ describe('session service', () => {
       mockedListParticipantConversations.mockResolvedValue(mockListParticipantsResponse as any)
       const result = await getActiveProxyAddresses(['+1112223333', '+2223334444'])
 
-      expect(result).toEqual({ '+1112223333': ['+3334445555', '+4445556666'], '+2223334444': ['+3334445555', '+4445556666'] })
+      expect(result).toEqual({ '+1112223333': ['+3334445555', '+3334449999', '+4445556666'], '+2223334444': ['+3334445555', '+3334449999', '+4445556666'] })
     })
 
     it('returns key with empty array if no active conversations', async () => {

tests/support/testSupport.ts

@@ -19,6 +19,48 @@ export const mockListParticipantsResponse = [{
   },
   participantSid: 'MB2d794fc4f4af4ee49ddcc1bdd8be6b94',
   participantUserSid: null
+}, {
+  accountSid: 'ACXXX',
+  chatServiceSid: 'ISXXX',
+  conversationState: 'inactive',
+  conversationTimers: {},
+  conversationUniqueName: null,
+  links: {
+    conversation: 'https://conversations.twilio.com/v1/Conversations/CH82681a28cddf4475afda30a2d94d9b29',
+    participant: 'https://conversations.twilio.com/v1/Conversations/CH82681a28cddf4475afda30a2d94d9b29/Participants/MB2d794fc4f4af4ee49ddcc1bdd8be6b94'
+  },
+  participantIdentity: null,
+  participantMessagingBinding: {
+    name: null,
+    level: null,
+    type: 'sms',
+    proxy_address: '+3334449999',
+    address: '+2223334444',
+    projected_address: null
+  },
+  participantSid: 'MB2d794fc4f4af4ee49ddcc1bdd8be6b94',
+  participantUserSid: null
+}, {
+  accountSid: 'ACXXX',
+  chatServiceSid: 'ISXXX',
+  conversationState: 'closed',
+  conversationTimers: {},
+  conversationUniqueName: null,
+  links: {
+    conversation: 'https://conversations.twilio.com/v1/Conversations/CH82681a28cddf4475afda30a2d94d9b29',
+    participant: 'https://conversations.twilio.com/v1/Conversations/CH82681a28cddf4475afda30a2d94d9b29/Participants/MB2d794fc4f4af4ee49ddcc1bdd8be6b94'
+  },
+  participantIdentity: null,
+  participantMessagingBinding: {
+    name: null,
+    level: null,
+    type: 'sms',
+    proxy_address: '+3334445555',
+    address: '+2223334444',
+    projected_address: null
+  },
+  participantSid: 'MB2d794fc4f4af4ee49ddcc1bdd8be6b94',
+  participantUserSid: null
 }, {
   accountSid: 'ACXXX',
   chatServiceSid: 'ISXXX',