Extract twiml logic from inboundCall controller to service

Author: cweems

src/controllers/inboundCall.ts

@@ -1,93 +1,14 @@
 import type { Request, Response } from "express";
-import VoiceResponse from "twilio/lib/twiml/VoiceResponse";
-
-import { getConversationByAddressPair } from "../utils/getConversationByAddressPair.util";
-
-import client from '../twilioClient'
-
-const generateTwiml = async (from: string, to: string) => {
-  let response = new VoiceResponse();
-
-  const conversation = await getConversationByAddressPair(from, to)
-
-  if (!conversation) {
-    console.log(`No active session (conversation) for ${from}.`)
-    response.say({
-      voice: process.env.CALL_ANNOUCEMENT_VOICE as any,
-      language: process.env.CALL_ANNOUCEMENT_LANGUAGE as any,
-    }, process.env.OUT_OF_SESSION_MESSAGE_FOR_CALL);
-  } else {
-    const participants = await client.conversations
-      .conversations(conversation.conversationSid)
-      .participants
-      .list()
-
-    const participantsToDial = participants.reduce((result, p) => {
-      if (p.messagingBinding.type === "sms" && p.messagingBinding.address != from) {
-          console.log(`Adding ${p.messagingBinding.address} to list of numbers to dial.\n`)
-
-          result.push({
-              address: p.messagingBinding.address,
-              proxyAddress: p.messagingBinding.proxy_address
-          })
-      }
-
-      return result;
-    }, [])
-
-    response.say({
-      voice: process.env.CALL_ANNOUCEMENT_VOICE as any,
-      language: process.env.CALL_ANNOUCEMENT_LANGUAGE as any
-    }, process.env.CONNECTING_CALL_ANNOUCEMENT);
-
-    if (participantsToDial.length > 1) {
-      const conferenceName = `${from}_at_${Date.now()}`
-
-      const callPromises = participantsToDial.map(pa => {
-          console.log(`Dialing ${pa.address} from ${pa.proxyAddress}...`);
-
-          return client.calls.create({
-              url: `https://${process.env.DOMAIN}/join-conference?conferenceName=${encodeURIComponent(conferenceName)}`,
-              to: pa.address,
-              from: pa.proxyAddress
-          });
-      });
-
-      await Promise.all(callPromises)
-
-      const dial = response.dial();
-      dial.conference({
-          endConferenceOnExit: true
-      }, conferenceName);
-
-
-    } else {
-      const callee = participantsToDial[0]
-      const dial = response.dial({
-        callerId: callee.proxyAddress
-      });
-
-      dial.number(callee.address);
-    }
-
-  }
-
-  return response;
-
-}
+import { generateTwiml } from "../services/inboundCall.service";
 
 export const post = async (
   req: Request,
   res: Response
 ) => {
-  const { body } = req.body;
-
   const from = req.body.From
-  const called = req.body.Called
-  console.log(req.body.From)
-  console.log(req.body.Called)
+  const to = req.body.Called
 
-  const twiml = await generateTwiml(from, called);
+  const twiml = await generateTwiml(from, to);
 
   res.set('Content-Type', 'text/xml')
   res.send(twiml.toString())

src/services/inboundCall.service.ts

@@ -0,0 +1,75 @@
+import VoiceResponse from "twilio/lib/twiml/VoiceResponse";
+
+import { getConversationByAddressPair } from "../utils/getConversationByAddressPair.util";
+
+import client from '../twilioClient'
+
+export const generateTwiml = async (from: string, to: string) => {
+  let response = new VoiceResponse();
+
+  const conversation = await getConversationByAddressPair(from, to)
+
+  if (!conversation) {
+    console.log(`No active session (conversation) for ${from}.`)
+    response.say({
+      voice: process.env.CALL_ANNOUCEMENT_VOICE as any,
+      language: process.env.CALL_ANNOUCEMENT_LANGUAGE as any,
+    }, process.env.OUT_OF_SESSION_MESSAGE_FOR_CALL);
+  } else {
+    const participants = await client.conversations
+      .conversations(conversation.conversationSid)
+      .participants
+      .list()
+
+    const participantsToDial = participants.reduce((result, p) => {
+      if (p.messagingBinding.type === "sms" && p.messagingBinding.address != from) {
+          console.log(`Adding ${p.messagingBinding.address} to list of numbers to dial.\n`)
+
+          result.push({
+              address: p.messagingBinding.address,
+              proxyAddress: p.messagingBinding.proxy_address
+          })
+      }
+
+      return result;
+    }, [])
+
+    response.say({
+      voice: process.env.CALL_ANNOUCEMENT_VOICE as any,
+      language: process.env.CALL_ANNOUCEMENT_LANGUAGE as any
+    }, process.env.CONNECTING_CALL_ANNOUCEMENT);
+
+    if (participantsToDial.length > 1) {
+      const conferenceName = `${from}_at_${Date.now()}`
+
+      const callPromises = participantsToDial.map(pa => {
+          console.log(`Dialing ${pa.address} from ${pa.proxyAddress}...`);
+
+          return client.calls.create({
+              url: `https://${process.env.DOMAIN}/join-conference?conferenceName=${encodeURIComponent(conferenceName)}`,
+              to: pa.address,
+              from: pa.proxyAddress
+          });
+      });
+
+      await Promise.all(callPromises)
+
+      const dial = response.dial();
+      dial.conference({
+          endConferenceOnExit: true
+      }, conferenceName);
+
+
+    } else {
+      const callee = participantsToDial[0]
+      const dial = response.dial({
+        callerId: callee.proxyAddress
+      });
+
+      dial.number(callee.address);
+    }
+
+  }
+
+  return response;
+}