Skip to content
Discussion options

You must be logged in to vote

Hi @ishah-twilio

I took a look at the codesandbox. Thanks for putting that together. I'm not seeing any glaring issues at the moment. A few answers/suggetions:

spacing padding / gutter of fields
Accessibility issues
correct usage of components

That all looks pretty good. I'll share with design to see if they have any further suggestions.

Copy (is it clear indication for what is required and what is optional and when)

It may be helpful to add some copy about why certain fields are disabled. Something around "In order to set a data limit, enable data..."

Should required field show red dot icon indication when disabled?

I don't think input fields should be set to required and disabled …

Replies: 1 comment 1 reply

Comment options

You must be logged in to vote
1 reply
@corinne-nagel
Comment options

Answer selected by corinne-nagel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants