Skip to content
Discussion options

You must be logged in to vote

Hi @GiantRobots

I forked your CodeSandbox and played around with the layout in another example. I left your other examples in place for comparison. I'm just using Box here. Flex can be a little too opinionated sometimes. We need to reevaluate that one.

For the icon alignment, we usually say you can solve that with a line-height, but that doesn't quite work with long headings that wrap lines because that line-height makes the text look cramped. I when with a relatively positioned Box wrapping the PopoverButton.

I also left a comment in the code about the button group needing to be radio inputs instead of actual buttons in order to be accessible.

Have a look and let us know if you have any …

Replies: 2 comments 1 reply

Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
1 reply
@GiantRobots
Comment options

Answer selected by GiantRobots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants