Report - Filter Data by Date range -- Canned date range vs. Custom date range selection #1917
-
Beta Was this translation helpful? Give feedback.
Replies: 8 comments 2 replies
-
Hey @ishah-twilio 👋 Could you please clarify what the ask is here? Thank you! |
Beta Was this translation helpful? Give feedback.
-
Hey @ishah-twilio @azhengtwilio - thanks for sharing this with us, and apologies for the delayed reply. To answer your questions:
|
Beta Was this translation helpful? Give feedback.
-
@katieporter / @azhengtwilio Thank you for following up on this. I looked at Filter pattern contribution Sarah shared). And I saw one of the option presented to use the popover for customer date range selection using datepicker. I created sandbox sample with existing components, using popover and combining "custom" date range selection as a menu option with other canned reports. https://codesandbox.io/s/date-range-hct20?file=/src/index.tsx Can we do this instead of option that we presented earlier? Any thoughts? Concerns? I will track the user feedback metrics. |
Beta Was this translation helpful? Give feedback.
-
Hey @ishah-twilio! Just wanted to circle back here after your office hours session last week. As discussed then, putting the calendar into either a standalone button or in the suffix on the Combobox works from the perspective of general component usage and accessibility, so whichever one works better for you is great. Let us know if you have any additional questions or concerns on this one. And nice work putting together a custom date range picker giving the current constraints with the Date Picker component! This is looking really good. |
Beta Was this translation helpful? Give feedback.
-
@katieporter I attended the DSys office hours. And I thought there was a concerns some unsolved interaction with proposed option 2. What should be interaction when custom date range is selected? Should we show custom as the menu item? If yes, what should be the interaction? |
Beta Was this translation helpful? Give feedback.
-
Hey @ishah-twilio, sorry, I didn't realize there were still open questions following office hours! After chatting with the team a bit, I put together a very quick mock to outline a proposal. Basically, there is a "custom" option in the Combobox from the start, and clicking it would open the Popover on the calendar button. Clicking the calendar button would of course also open the Popover. Applying a custom date in the Popover would close it and add the custom date range to the Combobox. Let me know if that suggestion makes sense. Also very open to your suggestions since you are much closer to the product and your specific needs! |
Beta Was this translation helpful? Give feedback.
-
@katieporter Thank you for your reply. Any guidance on error usecase? If user selects Custom but does not pick the date range in the popover / close the popover -- where do we show the error? |
Beta Was this translation helpful? Give feedback.
-
@ishah-twilio Thanks for chatting IRL about this to give more context! Per our discussion, we're suggesting that you can include a default start and end date to forgo needing to show an error state. We also discussed not changing the data below until the submit button "apply" has been selected. Thanks for the collaboration on this! |
Beta Was this translation helpful? Give feedback.
@ishah-twilio Thanks for chatting IRL about this to give more context! Per our discussion, we're suggesting that you can include a default start and end date to forgo needing to show an error state. We also discussed not changing the data below until the submit button "apply" has been selected. Thanks for the collaboration on this!