Skip to content

Commit 09c79e1

Browse files
author
timmydoza
authored
Merge pull request #24 from twilio-labs/fix-delete-command
Improve delete command.
2 parents d6f590f + 0104052 commit 09c79e1

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 0.1.4
4+
5+
### Maintenance
6+
7+
* Updated `twilio rtc:apps:video:delete` command so that it doesn't check for serverless environments before deleting the app. This allows the command to delete the app even when no environments exist.
8+
39
## 0.1.3
410

511
### Features

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# @twilio-labs/plugin-rtc
22

3-
![npm](https://img.shields.io/npm/v/@twilio-labs/plugin-rtc)
3+
[![npm](https://img.shields.io/npm/v/@twilio-labs/plugin-rtc)](https://www.npmjs.com/package/@twilio-labs/plugin-rtc)
44
[![CircleCI](https://circleci.com/gh/twilio-labs/plugin-rtc.svg?style=svg)](https://circleci.com/gh/twilio-labs/plugin-rtc)
55

66
This plugin adds functionality to the [Twilio CLI](https://github.com/twilio/twilio-cli) which supports developing and deploying real-time communication apps.

src/commands/rtc/apps/video/delete.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
const { getAppInfo } = require('../../../../helpers');
1+
const { findApp } = require('../../../../helpers');
22
const { TwilioClientCommand } = require('@twilio/cli-core').baseCommands;
33

44
class DeleteCommand extends TwilioClientCommand {
55
async run() {
66
await super.run();
7-
const appInfo = await getAppInfo.call(this);
7+
const appInfo = await findApp.call(this);
88

99
if (appInfo) {
1010
await this.twilioClient.serverless.services(appInfo.sid).remove();
11-
console.log(`Removed app with Passcode: ${appInfo.passcode}`);
11+
console.log('Successfully deleted app.');
1212
} else {
13-
console.log('There is no app to delete');
13+
console.log('There is no app to delete.');
1414
}
1515
}
1616
}

0 commit comments

Comments
 (0)