Update token server to use create_room parameter

Author: Tim Mendoza

src/video-token-server.js

@@ -16,12 +16,23 @@ module.exports.handler = async (context, event, callback) => {
     ROOM_TYPE,
   } = context;
 
-  const { user_identity, room_name, passcode } = event;
+  const { user_identity, room_name, passcode, create_room = true } = event;
   const [, appID, serverlessID] = DOMAIN_NAME.match(/-?(\d*)-(\d+)(?:-\w+)?.twil.io$/);
 
   let response = new Twilio.Response();
   response.appendHeader('Content-Type', 'application/json');
 
+  if (typeof create_room !== 'boolean') {
+    response.setStatusCode(400);
+    response.setBody({
+      error: {
+        message: 'invalid parameter',
+        explanation: 'A boolean value must be provided for the create_room parameter',
+      },
+    });
+    return callback(null, response);
+  }
+
   if (Date.now() > API_PASSCODE_EXPIRY) {
     response.setStatusCode(401);
     response.setBody({
@@ -56,21 +67,23 @@ module.exports.handler = async (context, event, callback) => {
     return callback(null, response);
   }
 
-  const client = context.getTwilioClient();
+  if (create_room) {
+    const client = context.getTwilioClient();
 
-  try {
-    await client.video.rooms.create({ uniqueName: room_name, type: ROOM_TYPE });
-  } catch (e) {
-    // Ignore 53113 error (room already exists). See: https://www.twilio.com/docs/api/errors/53113
-    if (e.code !== 53113) {
-      response.setStatusCode(500);
-      response.setBody({
-        error: {
-          message: 'error creating room',
-          explanation: 'Something went wrong when creating a room.',
-        },
-      });
-      return callback(null, response);
+    try {
+      await client.video.rooms.create({ uniqueName: room_name, type: ROOM_TYPE });
+    } catch (e) {
+      // Ignore 53113 error (room already exists). See: https://www.twilio.com/docs/api/errors/53113
+      if (e.code !== 53113) {
+        response.setStatusCode(500);
+        response.setBody({
+          error: {
+            message: 'error creating room',
+            explanation: 'Something went wrong when creating a room.',
+          },
+        });
+        return callback(null, response);
+      }
     }
   }
 
@@ -81,6 +94,6 @@ module.exports.handler = async (context, event, callback) => {
   const videoGrant = new VideoGrant({ room: room_name });
   token.addGrant(videoGrant);
   response.setStatusCode(200);
-  response.setBody({ token: token.toJwt(), room_type: ROOM_TYPE });
+  response.setBody({ token: token.toJwt(), room_type: create_room ? ROOM_TYPE : null });
   return callback(null, response);
 };

test/video-token-server.test.js

@@ -58,6 +58,27 @@ describe('the video-token-server', () => {
     });
   });
 
+  it('should return an "invalid parameter" error when the create_room parameter is not a boolean', async () => {
+    Date.now = () => 5;
+
+    await handler(
+      mockContext,
+      { passcode: '12345612345678', user_identity: 'test identity', create_room: 'no thanks' },
+      callback
+    );
+
+    expect(callback).toHaveBeenCalledWith(null, {
+      body: {
+        error: {
+          message: 'invalid parameter',
+          explanation: 'A boolean value must be provided for the create_room parameter',
+        },
+      },
+      headers: { 'Content-Type': 'application/json' },
+      statusCode: 400,
+    });
+  });
+
   it('should return a "missing user_identity" error when the "user_identity" parameter is not supplied', () => {
     handler(mockContext, { passcode: '12345612345678' }, callback);
 
@@ -140,7 +161,7 @@ describe('the video-token-server', () => {
       expect(jwt.verify(callback.mock.calls[0][1].body.token, 'api_secret')).toBeTruthy();
     });
 
-    it('should create a new room and return a valid token when passcode', async () => {
+    it('should create a new room and return a valid token', async () => {
       await handler(
         mockContext,
         { passcode: '12345612345678', room_name: 'test-room', user_identity: 'test-user' },
@@ -155,6 +176,21 @@ describe('the video-token-server', () => {
       });
     });
 
+    it('should return a valid token without creating a room when "create_room" is false', async () => {
+      await handler(
+        mockContext,
+        { passcode: '12345612345678', room_name: 'test-room', user_identity: 'test-user', create_room: false },
+        callback
+      );
+
+      expect(mockCreateFunction).not.toHaveBeenCalled();
+      expect(callback).toHaveBeenCalledWith(null, {
+        body: { token: expect.any(String), room_type: null },
+        headers: { 'Content-Type': 'application/json' },
+        statusCode: 200,
+      });
+    });
+
     it('should return a valid token when passcode when the room already exists', async () => {
       mockCreateFunction.mockImplementation(() => Promise.reject({ code: 53113 }));