Merge pull request #44 from twilio-labs/AHOYAPPS-855-always-return-room-type

Update plugin to always return room_type parameter

Author: timmydoza

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.4.0
+
+### Maintenence
+
+- Updated the logic in the video token server so that it always returns the `room_type` parameter.
+- Upgraded @twilio/cli-core from 5.8.1 to 5.9.0
+
 ## 0.3.0
 
 ### Enhancements

README.md

@@ -110,7 +110,7 @@ POST /token
 ```json
 {
   "token": "0000000000000000.0000000000000000000000.00000000000000000",
-  "room_type": "group" | "group-small" | "peer-to-peer" | null
+  "room_type": "group" | "group-small" | "peer-to-peer"
 }
 ```
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@twilio-labs/plugin-rtc",
-  "version": "0.3.1",
+  "version": "0.4.0",
   "description": "A Twilio-CLI plugin for real-time communication apps",
   "main": "index.js",
   "publishConfig": {

package.json

@@ -94,6 +94,6 @@ module.exports.handler = async (context, event, callback) => {
   const videoGrant = new VideoGrant({ room: room_name });
   token.addGrant(videoGrant);
   response.setStatusCode(200);
-  response.setBody({ token: token.toJwt(), room_type: create_room ? ROOM_TYPE : null });
+  response.setBody({ token: token.toJwt(), room_type: ROOM_TYPE });
   return callback(null, response);
 };

src/video-token-server.js

@@ -147,7 +147,7 @@ describe('the RTC Twilio-CLI Plugin', () => {
           .post(`${URL}/token`)
           .send({ passcode, room_name: ROOM_NAME, user_identity: 'test user', create_room: false });
         expect(jwt.decode(body.token).grants).toEqual({ identity: 'test user', video: { room: ROOM_NAME } });
-        expect(body.room_type).toEqual(null);
+        expect(body.room_type).toEqual('group');
 
         try {
           await twilioClient.video.rooms(ROOM_NAME).fetch();

test/e2e/e2e.test.js

@@ -185,7 +185,7 @@ describe('the video-token-server', () => {
 
       expect(mockCreateFunction).not.toHaveBeenCalled();
       expect(callback).toHaveBeenCalledWith(null, {
-        body: { token: expect.any(String), room_type: null },
+        body: { token: expect.any(String), room_type: 'group' },
         headers: { 'Content-Type': 'application/json' },
         statusCode: 200,
       });