Add parameter validation and tests to recordingrules route

Author: Tim Mendoza

src/serverless/functions/recordingrules.js

@@ -9,15 +9,37 @@ module.exports.handler = async (context, event, callback) => {
   const authHandler = require(Runtime.getAssets()['/auth-handler.js'].path);
   authHandler(context, event, callback);
 
-  const client = twilio(context.ACCOUNT_SID, context.AUTH_TOKEN);
-
   let response = new Twilio.Response();
   response.appendHeader('Content-Type', 'application/json');
 
+  const { room_sid, rules } = event;
+
+  if (typeof room_sid === 'undefined') {
+    response.setStatusCode(400);
+    response.setBody({
+      error: {
+        message: 'missing room_sid',
+        explanation: 'The room_sid parameter is missing.',
+      },
+    });
+    return callback(null, response);
+  }
+
+  if (typeof rules === 'undefined') {
+    response.setStatusCode(400);
+    response.setBody({
+      error: {
+        message: 'missing rules',
+        explanation: 'The rules parameter is missing.',
+      },
+    });
+    return callback(null, response);
+  }
+
+  const client = twilio(context.ACCOUNT_SID, context.AUTH_TOKEN);
+
   try {
-    const recordingRulesResponse = await client.video
-      .rooms(event.room_sid)
-      .recordingRules.update({ rules: event.rules });
+    const recordingRulesResponse = await client.video.rooms(room_sid).recordingRules.update({ rules });
     response.setStatusCode(200);
     response.setBody(recordingRulesResponse);
   } catch (err) {

test/serverless/functions/recordingrules.test.js

@@ -0,0 +1,88 @@
+const { handler } = require('../../../src/serverless/functions/recordingrules');
+const twilio = require('twilio');
+
+const mockUpdateFn = jest.fn(() => Promise.resolve('mockSuccessResponse'));
+
+const mockClient = jest.fn(() => ({
+  video: {
+    rooms: jest.fn(() => ({
+      recordingRules: {
+        update: mockUpdateFn,
+      },
+    })),
+  },
+}));
+
+jest.mock('twilio');
+twilio.mockImplementation(mockClient);
+
+describe('the recordingrules function', () => {
+  it('should correctly respond when a room update is successful', async () => {
+    const mockCallback = jest.fn();
+
+    await handler(
+      { ACCOUNT_SID: '1234', AUTH_TOKEN: '2345' },
+      { room_sid: 'mockRoomSid', rules: 'mockRules' },
+      mockCallback
+    );
+
+    expect(mockClient).toHaveBeenCalledWith('1234', '2345');
+    expect(mockCallback).toHaveBeenCalledWith(null, {
+      body: 'mockSuccessResponse',
+      headers: { 'Content-Type': 'application/json' },
+      statusCode: 200,
+    });
+  });
+
+  it('should correctly respond when a room update is not successful', async () => {
+    const mockCallback = jest.fn();
+    const mockError = { message: 'mockErrorMesage', code: 123 };
+    mockUpdateFn.mockImplementationOnce(() => Promise.reject(mockError));
+
+    await handler(
+      { ACCOUNT_SID: '1234', AUTH_TOKEN: '2345' },
+      { room_sid: 'mockRoomSid', rules: 'mockRules' },
+      mockCallback
+    );
+
+    expect(mockCallback).toHaveBeenCalledWith(null, {
+      body: { error: mockError },
+      headers: { 'Content-Type': 'application/json' },
+      statusCode: 500,
+    });
+  });
+
+  it('should return a "missing room_sid" error when the room_sid is absent', async () => {
+    const mockCallback = jest.fn();
+
+    await handler({ ACCOUNT_SID: '1234', AUTH_TOKEN: '2345' }, { rules: 'mockRules' }, mockCallback);
+
+    expect(mockCallback).toHaveBeenCalledWith(null, {
+      body: {
+        error: {
+          message: 'missing room_sid',
+          explanation: 'The room_sid parameter is missing.',
+        },
+      },
+      headers: { 'Content-Type': 'application/json' },
+      statusCode: 400,
+    });
+  });
+
+  it('should return a "missing rules" error when the rules array is absent', async () => {
+    const mockCallback = jest.fn();
+
+    await handler({ ACCOUNT_SID: '1234', AUTH_TOKEN: '2345' }, { room_sid: 'mockSid' }, mockCallback);
+
+    expect(mockCallback).toHaveBeenCalledWith(null, {
+      body: {
+        error: {
+          message: 'missing rules',
+          explanation: 'The rules parameter is missing.',
+        },
+      },
+      headers: { 'Content-Type': 'application/json' },
+      statusCode: 400,
+    });
+  });
+});

test/setupTests.js

@@ -32,4 +32,4 @@ global.Runtime = {
 };
 
 // Mocking this as a no-op since this function is tested in 'tests/serverless/assets/verify_passcode.ts'.
-jest.mock(`${__dirname}/../src/serverless/assets/verify_passcode.js`, () => () => {});
+jest.doMock(verifyPasscodePath, () => () => {});