Incorrect handling of prefixed_collapsible_map parameters

[maylonpedroso]

Issue Summary

Incorrect handling of PREFIXED_COLLAPSIBLE_MAP. The CLI is not decomposing the parameter value in the expected parameters to send in the request.

Steps to Reproduce

Running:

twilio api:lookups:v1:phone-numbers:fetch \
    --phone-number +16502530000 \
    --add-ons payfone_tcpa_compliance \
    --add-ons-data "{\"payfone_tcpa_compliance.RightPartyContactedDate\": \"20160101\"}"

Should make a GET request to:

https://lookups.twilio.com/v1/PhoneNumbers/+16502530000?AddOns=payfone_tcpa_compliance&AddOns.payfone_tcpa_compliance.RightPartyContactedDate=20160101

but is doing:

https://lookups.twilio.com/v1/PhoneNumbers/+16502530000?AddOns=payfone_tcpa_compliance&AddOnsData={%22payfone_tcpa_compliance.RightPartyContactedDate%22:%2220160101%22}

Technical details:

• twilio-cli Version: 1.4.1 linux-x64
• Node.js Version: v8.13.0

[thinkingserious]

Hello @maylonpedroso,

Thanks for the heads up!

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

With best regards,

Elmer

[childish-sambino]

I've looked into this a bit more and unfortunately it's not a simple fix. The closest thing OpenAPI supports to this is style: deepObject for query parameter serialization.

Given that this is the only Twilio API that uses PREFIXED_COLLAPSIBLE_MAP, I'm switching this to a community enhancement. PRs are welcome to add this, but our team is unlikely to build this out.

[modest]

This was in the tutorial for add-ons and has an incorrect example in Twilio's own documentation. I almost gave up on the CLI entirely before finding this post.

https://www.twilio.com/docs/add-ons?code-sample=code-deterministic-tcpa-compliance-with-lookup-and-the-payfone-add-on&code-language=twilio-cli&code-sdk-version=1.x