chore: review context changes #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (c *Client) SendRequest(method string, rawURL string, data url.Values, | ||
| headers map[string]interface{}, body ...byte) (*http.Response, error) { | ||
|
|
||
| return c.SendRequestWithContext(context.TODO(), method, rawURL, data, headers, body...) |
Contributor
There was a problem hiding this comment.
Suggested change
| return c.SendRequestWithContext(context.TODO(), method, rawURL, data, headers, body...) | |
| return c.SendRequestWithContext(context.Background(), method, rawURL, data, headers, body...) |
Contributor
There was a problem hiding this comment.
For all of these - TODO is "we plan to add context later" but there's no way for us to do that.
| Client: client, | ||
| Edge: os.Getenv("TWILIO_EDGE"), | ||
| Region: os.Getenv("TWILIO_REGION"), | ||
| ctx: context.TODO(), |
Contributor
There was a problem hiding this comment.
I don't see where we use this, it makes me nervous that we're using this here
| return NewApiService(twilio.NewRequestHandler(client)) | ||
| } | ||
|
|
||
| func NewApiServiceWithCtx(requestHandler *twilio.RequestHandler) *ApiService { |
Contributor
There was a problem hiding this comment.
Not sure we need this method
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Preview PR: twilio/twilio-oai-generator#651
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.