chore: remove auth from request.__str__() (#887)

* chore: remove auth from request.__str__()

* chore: remove auth from request.__str__()

* chore: skip authorization key in headers

Author: tiwarishubham635

tests/unit/http/test_http_client.py

@@ -10,6 +10,7 @@
 from twilio.base.version import Version
 from twilio.http.http_client import TwilioHttpClient
 from twilio.http.response import Response
+from twilio.http.request import Request
 
 
 class TestHttpClientRequest(unittest.TestCase):
@@ -293,6 +294,43 @@ def test_session_not_preserved(self):
         self.assertEqual(response_2.content, "response_2")
 
 
+class TestTwilioRequest(unittest.TestCase):
+    def test_str(self):
+
+        req = Request(
+            method="POST",
+            url="https://api.twilio.com/2010-04-01/Accounts.json",
+            auth=("AC123", "token"),
+            params={"PageSize": "1"},
+            data={"FriendlyName": "My New Account"},
+            headers={"X-Custom-Header": "Value"},
+        )
+        expected = (
+            "POST https://api.twilio.com/2010-04-01/Accounts.json?PageSize=1\n"
+            ' -d "FriendlyName=My New Account"\n'
+            ' -H "X-Custom-Header: Value"'
+        )
+        self.assertEqual(expected, req.__str__())
+
+    def test_str_excludes_authorization_header(self):
+        req = Request(
+            method="POST",
+            url="https://api.twilio.com/2010-04-01/Accounts.json",
+            params={"PageSize": "1"},
+            data={"FriendlyName": "My New Account"},
+            headers={
+                "Authorization": "Bearer secret-token",
+                "X-Custom-Header": "Value"
+            },
+        )
+        expected = (
+            "POST https://api.twilio.com/2010-04-01/Accounts.json?PageSize=1\n"
+            ' -d "FriendlyName=My New Account"\n'
+            ' -H "X-Custom-Header: Value"'
+        )
+        self.assertEqual(expected, req.__str__())
+
+
 class MyVersion(Version):
     def __init__(self, domain):
         super().__init__(domain, "v1")

twilio/http/request.py

@@ -56,10 +56,6 @@ def __eq__(self, other) -> bool:
         )
 
     def __str__(self) -> str:
-        auth = ""
-        if self.auth and self.auth != Match.ANY:
-            auth = "{} ".format(self.auth)
-
         params = ""
         if self.params and self.params != Match.ANY:
             params = "?{}".format(urlencode(self.params, doseq=True))
@@ -75,11 +71,10 @@ def __str__(self) -> str:
         headers = ""
         if self.headers and self.headers != Match.ANY:
             headers = "\n{}".format(
-                "\n".join(' -H "{}: {}"'.format(k, v) for k, v in self.headers.items())
+                "\n".join(' -H "{}: {}"'.format(k, v) for k, v in self.headers.items() if k.lower() != "authorization")
             )
 
-        return "{auth}{method} {url}{params}{data}{headers}".format(
-            auth=auth,
+        return "{method} {url}{params}{data}{headers}".format(
             method=self.method,
             url=self.url,
             params=params,