allow creating feedback in one request

Author: Doug Black

tests/test_call_feedback.py

@@ -51,6 +51,35 @@ def test_create_call_feedback(self, request):
             timeout=ANY,
         )
 
+    @patch('twilio.rest.resources.base.make_twilio_request')
+    def test_create_call_feedback_one_request(self, request):
+        resp = create_mock_json('tests/resources/call_feedback.json')
+        resp.status_code = 201
+        request.return_value = resp
+
+        base_uri = 'https://api.twilio.com/2010-04-01/Accounts/AC123'
+        account_sid = 'AC123'
+        auth = (account_sid, "token")
+
+        calls = Calls(base_uri, auth)
+        uri = "%s/Calls/CA123/Feedback" % base_uri
+        feedback = calls.feedback(
+            'CA123',
+            quality_score=5,
+            issue=['imperfect-audio', 'post-dial-delay']
+        )
+
+        exp_data = {
+            'QualityScore': 5,
+            'Issue': ['imperfect-audio', 'post-dial-delay'],
+        }
+
+        assert_equal(['imperfect-audio', 'post-dial-delay'], feedback.issues)
+        request.assert_called_with(
+            "POST", uri,
+            data=exp_data, auth=auth,
+        )
+
 
 class CallFeedbackSummaryTest(unittest.TestCase):
 

twilio/rest/__init__.py

@@ -26,6 +26,8 @@
 from .resources import Transcriptions
 from .resources import UNSET_TIMEOUT
 from .resources import Usage
+from .resources import CallFeedbackFactory
+from .resources import CallFeedback
 
 
 def find_credentials(environ=None):
@@ -133,6 +135,20 @@ def members(self, queue_sid):
         base_uri = "%s/Queues/%s" % (self.account_uri, queue_sid)
         return Members(base_uri, self.auth, self.timeout)
 
+    def feedback(self, call_sid):
+        """
+        Return a :class:`CallFeedback <twilio.rest.resources.CallFeedback>`
+        instance for the :class:`Call <twilio.rest.resources.calls.Call>`
+        with the given call_sid
+        """
+        base_uri = "%s/Calls/%s/Feedback" % (self.account_uri, call_sid)
+        call_feedback_list = CallFeedbackFactory(
+            base_uri,
+            self.auth,
+            self.timeout
+        )
+        return CallFeedback(call_feedback_list)
+
     def request(self, path, method=None, vars=None):
         """sends a request and gets a response from the Twilio REST API
 

twilio/rest/resources/__init__.py

@@ -24,6 +24,10 @@
 )
 from .calls import Call, Calls
 from .caller_ids import CallerIds, CallerId
+from .call_feedback import (
+    CallFeedbackFactory, CallFeedback, CallFeedbackSummary,
+    CallFeedbackSummaryInstance
+)
 from .connection import Connection
 from .sandboxes import Sandbox, Sandboxes
 from .sms_messages import (

twilio/rest/resources/call_feedback.py

@@ -1,4 +1,4 @@
-from twilio.rest.resources import (
+from . import (
     ListResource,
     InstanceResource,
     transform_params,

twilio/rest/resources/calls.py

@@ -4,7 +4,7 @@
     CallFeedbackFactory,
     CallFeedbackSummary,
 )
-from .util import normalize_dates, parse_date
+from .util import normalize_dates, parse_date, transform_params
 from . import InstanceResource, ListResource
 
 
@@ -153,3 +153,19 @@ def route(self, sid, url, method="POST"):
         :returns: Updated :class:`Call` resource
         """
         return self.update(sid, url=url, method=method)
+
+    def feedback(self, sid, quality_score, issue=None):
+        """ Create feedback for the given call.
+
+        :param sid: A Call Sid for a specific call
+        :param quality_score: The quality of the call
+        :param issue: A list of issues experienced during the call
+        :returns: A :class:`CallFeedback` object
+        """
+        uri = "%s/%s" % (self.uri, sid)
+        call_feedback_factory = CallFeedbackFactory(
+            uri, self.auth, self.timeout
+        )
+        return call_feedback_factory.create(
+            quality_score=quality_score, issue=issue
+        )