Move redirect to xml value

Author: jingming

tests/unit/twiml/test_messaging_response.py

@@ -19,15 +19,15 @@ def test_response(self):
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'
         )
 
     def test_response_chain(self):
         r = MessagingResponse().message('Hello').redirect(url='example.com')
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Message>Hello</Message><Redirect>example.com</Redirect></Response>'
         )
 
 
@@ -74,5 +74,5 @@ def test_redirect(self):
 
         assert_equal(
             self.strip(r),
-            '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect url="example.com" /></Response>'
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Redirect>example.com</Redirect></Response>'
         )

twilio/twiml/messaging_response.py

@@ -42,12 +42,12 @@ def message(self,
             **kwargs
         ))
 
-    def redirect(self, method=None, url=None, **kwargs):
+    def redirect(self, url, method=None, **kwargs):
         """
         Add a <Redirect> element
 
-        :param method: HTTP method
         :param url: URL to redirect to
+        :param method: HTTP method
         :param kwargs: other attributes
         :return: <Redirect> element
         """
@@ -124,5 +124,12 @@ class Redirect(TwiML):
     """
     <Redirect> element
     """
-    pass
+    def __init__(self, url, **kwargs):
+        """
+        Create a new <Redirect> element
+
+        :param url: redirect URL location
+        """
+        super(Redirect, self).__init__(**kwargs)
+        self.value = url