Organization api uptake changes

Author: AsabuHere

twilio/auth_strategy/auth_strategy.py

@@ -1,5 +1,4 @@
 from twilio.auth_strategy.auth_type import AuthType
-from enum import Enum
 from abc import abstractmethod
 
 
@@ -14,9 +13,7 @@ def auth_type(self) -> AuthType:
     @abstractmethod
     def get_auth_string(self) -> str:
         """Return the authentication string."""
-        pass
 
     @abstractmethod
     def requires_authentication(self) -> bool:
         """Return True if authentication is required, else False."""
-        pass

twilio/auth_strategy/auth_type.py

@@ -1,11 +1,12 @@
 from enum import Enum
 
+
 class AuthType(Enum):
-    ORGS_TOKEN = 'orgs_stoken'
-    NO_AUTH = 'noauth'
-    BASIC = 'basic'
-    API_KEY = 'api_key'
-    CLIENT_CREDENTIALS = 'client_credentials'
+    ORGS_TOKEN = "orgs_stoken"
+    NO_AUTH = "noauth"
+    BASIC = "basic"
+    API_KEY = "api_key"
+    CLIENT_CREDENTIALS = "client_credentials"
 
     def __str__(self):
-        return self.value
+        return self.value

twilio/auth_strategy/no_auth_strategy.py

@@ -1,5 +1,6 @@
 from auth_type import AuthType
 
+
 class NoAuthStrategy(AuthStrategy):
     def __init__(self):
         super().__init__(AuthType.NO_AUTH)
@@ -8,4 +9,4 @@ def get_auth_string(self) -> str:
         return ""
 
     def requires_authentication(self) -> bool:
-        return False
+        return False

twilio/auth_strategy/token_auth_strategy.py

@@ -1,7 +1,7 @@
 import jwt
 import threading
 import logging
-from datetime import datetime, timedelta
+from datetime import datetime
 
 from twilio.auth_strategy.auth_type import AuthType
 from twilio.auth_strategy.auth_strategy import AuthStrategy
@@ -25,16 +25,16 @@ def requires_authentication(self) -> bool:
         return True
 
     def fetch_token(self):
-        self.logger.info("New token fetched for accessing organization API")
         if self.token is None or self.token == "" or self.is_token_expired(self.token):
-             with self.lock:
+            # with self.lock:
                 if self.token is None or self.token == "" or self.is_token_expired(self.token):
+                    self.logger.info("New token fetched for accessing organization API")
                     self.token = self.token_manager.fetch_access_token()
 
     def is_token_expired(self, token):
         try:
             decoded = jwt.decode(token, options={"verify_signature": False})
-            exp = decoded.get('exp')
+            exp = decoded.get("exp")
 
             if exp is None:
                 return True  # No expiration time present, consider it expired
@@ -46,4 +46,4 @@ def is_token_expired(self, token):
             return True  # Token is invalid
         except Exception as e:
             print(f"An error occurred: {e}")
-            return True
+            return True

twilio/base/client_base.py

@@ -7,7 +7,6 @@
 from twilio.http import HttpClient
 from twilio.http.http_client import TwilioHttpClient
 from twilio.http.response import Response
-from twilio.auth_strategy.auth_type import AuthType
 from twilio.credential.credential_provider import CredentialProvider
 
 
@@ -88,27 +87,26 @@ def request(
 
         :returns: Response from the Twilio API
         """
-
         headers = self.get_headers(method, headers)
 
         ##If credential provider is provided by user, get the associated auth strategy
         ##Using the auth strategy, fetch the auth string and set it to authorization header
         if self.credential_provider:
+
             auth_strategy = self.credential_provider.to_auth_strategy()
             headers["Authorization"] = auth_strategy.get_auth_string()
         elif self.username is not None and self.password is not None:
             auth = self.get_auth(auth)
         else:
             auth = None
 
-
         uri = self.get_hostname(uri)
-
+        filtered_data = self.copy_non_none_values(data)
         return self.http_client.request(
             method,
             uri,
             params=params,
-            data=data,
+            data=filtered_data,
             headers=headers,
             auth=auth,
             timeout=timeout,
@@ -147,7 +145,6 @@ async def request_async(
                 "http_client must be asynchronous to support async API requests"
             )
 
-
         headers = self.get_headers(method, headers)
 
         ##If credential provider is provided by user, get the associated auth strategy
@@ -162,18 +159,25 @@ async def request_async(
             auth = None
 
         uri = self.get_hostname(uri)
-
+        filtered_data = self.copy_non_none_values(data)
         return await self.http_client.request(
             method,
             uri,
             params=params,
-            data=data,
+            data=filtered_data,
             headers=headers,
             auth=auth,
             timeout=timeout,
             allow_redirects=allow_redirects,
         )
 
+    def copy_non_none_values(self, data):
+        if isinstance(data, dict):
+            return {k: self.copy_non_none_values(v) for k, v in data.items() if v is not None}
+        elif isinstance(data, list):
+            return [self.copy_non_none_values(item) for item in data if item is not None]
+        return data
+
     def get_auth(self, auth: Optional[Tuple[str, str]]) -> Tuple[str, str]:
         """
         Get the request authentication object
@@ -252,6 +256,20 @@ def get_hostname(self, uri: str) -> str:
         )
         return str(urlunparse(parsed_url))
 
+    def remove_nulls(self, data):
+        res = {}
+        for key, sub_dict in data.items():
+            temp_dict = {}
+            if type(sub_dict) != str and sub_dict is not None:
+                for sub_key, sub_value in sub_dict.items():
+                    if sub_value is not None:
+                        temp_dict[sub_key] = sub_value
+            if  type(sub_dict) == str:
+                temp_dict = sub_dict
+            if temp_dict:
+                res[key] = temp_dict
+        return res
+
     def __repr__(self) -> str:
         """
         Provide a friendly representation

twilio/base/page.py

@@ -77,6 +77,8 @@ def load_page(self, payload: Dict[str, Any]):
             key = keys - self.META_KEYS
             if len(key) == 1:
                 return payload[key.pop()]
+            if "Resources" in payload:
+                return payload["Resources"]
 
         raise TwilioException("Page Records can not be deserialized")
 

twilio/base/version.py

@@ -164,6 +164,10 @@ async def fetch_async(
             timeout=timeout,
             allow_redirects=allow_redirects,
         )
+        print('response')
+        print(response)
+
+
 
         return self._parse_fetch(method, uri, response)
 

twilio/credential/credential_provider.py

@@ -1,5 +1,6 @@
 from twilio.auth_strategy.auth_type import AuthType
 
+
 class CredentialProvider:
     def __init__(self, auth_type: AuthType):
         self._auth_type = auth_type

twilio/credential/orgs_credential_provider.py

@@ -1,5 +1,3 @@
-
-
 from twilio.http.orgs_token_manager import OrgTokenManager
 from twilio.base.exceptions import TwilioException
 from twilio.credential.credential_provider import CredentialProvider
@@ -22,7 +20,9 @@ def __init__(self, client_id: str, client_secret: str, token_manager=None):
 
     def to_auth_strategy(self):
         if self.token_manager is None:
-            self.token_manager = OrgTokenManager(self.grant_type, self.client_id, self.client_secret)
+            self.token_manager = OrgTokenManager(
+                self.grant_type, self.client_id, self.client_secret
+            )
         if self.auth_strategy is None:
             self.auth_strategy = TokenAuthStrategy(self.token_manager)
         return self.auth_strategy

twilio/http/http_client.py

@@ -88,10 +88,12 @@ def request(
         }
         if headers and headers.get("Content-Type") == "application/json":
             kwargs["json"] = data
+        elif headers and headers.get("Content-Type") == "application/scim+json":
+            kwargs["json"] = data
         else:
             kwargs["data"] = data
         self.log_request(kwargs)
-        print(f'args : {kwargs}')
+        print(f"\nargs : {kwargs}")
         self._test_only_last_response = None
         session = self.session or Session()
         request = Request(**kwargs)
@@ -106,9 +108,12 @@ def request(
             prepped_request,
             allow_redirects=allow_redirects,
             timeout=timeout,
-            **settings
+            **settings,
         )
 
+        print(f"\nresponse : {response.text}")
+        print(f"\nresponse code : {response}")
+
         self.log_response(response.status_code, response)
 
         self._test_only_last_response = Response(