Add test for arrays of strings

Author: twistedfall

src/templ.rs

@@ -81,10 +81,7 @@ macro_rules! string_array_arg {
 			.iter()
 			.map(|x| ::std::ffi::CString::new(*x).expect("invalid C string"))
 			.collect::<::std::vec::Vec<_>>();
-		let $name = $name
-			.iter()
-			.map(|x| x.as_ptr())
-			.collect::<::std::vec::Vec<_>>();
+		let $name = $name.iter().map(|x| x.as_ptr()).collect::<::std::vec::Vec<_>>();
 	};
 }
 
@@ -95,11 +92,8 @@ macro_rules! string_array_arg_mut {
 			.iter()
 			.map(|x| ::std::ffi::CString::new(*x).expect("invalid C string"))
 			.collect::<::std::vec::Vec<_>>();
-		// Casting to mut below trusts on undefined CString behavior.
-		let mut $name = $name
-			.iter()
-			.map(|x| x.as_ptr().cast_mut())
-			.collect::<::std::vec::Vec<_>>();
+		// fixme: Casting to mut below trusts on undefined CString behavior.
+		let mut $name = $name.iter().map(|x| x.as_ptr().cast_mut()).collect::<::std::vec::Vec<_>>();
 	};
 }
 

tests/marshalling.rs

@@ -1,7 +1,7 @@
 //! Contains all tests that cover marshalling types to and from C++
 
 use opencv::core;
-use opencv::core::{Scalar, SparseMat, Tuple};
+use opencv::core::{CommandLineParser, Scalar, SparseMat, Tuple};
 use opencv::prelude::*;
 use opencv::Result;
 
@@ -273,3 +273,12 @@ fn tuple() -> Result<()> {
 // 	assert_eq!(mat.data_typed()?, mat_src.data_typed()?);
 // 	Ok(())
 // }
+
+#[test]
+fn string_array() -> Result<()> {
+	let args = ["test", "-a=b"];
+	let mut parser = CommandLineParser::new(i32::try_from(args.len())?, &args, "{a | | }")?;
+	assert!(parser.has("a")?);
+	assert_eq!("b", parser.get_str("a", true)?);
+	Ok(())
+}