all: fix lints

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: twmb

generate/validate_test.go

@@ -674,7 +674,7 @@ func TestValidateMiscDSLAgainstKafkaJSON(t *testing.T) {
 
 	for _, m := range mappings {
 		jsonPath := filepath.Join(kafkaDir, m.jsonPath)
-		data, err := os.ReadFile(jsonPath)
+		data, err := os.ReadFile(jsonPath) //nolint:gosec // path is constructed from test constant + env var, not user input
 		if err != nil {
 			t.Errorf("reading %s: %v", m.jsonPath, err)
 			continue

pkg/kgo/config.go

@@ -186,6 +186,7 @@ type cfg struct {
 	sessionTimeout    time.Duration
 	rebalanceTimeout  time.Duration
 	heartbeatInterval time.Duration
+
 	onAssigned func(context.Context, *Client, map[string][]int32)
 	onRevoked  func(context.Context, *Client, map[string][]int32)
 	onLost     func(context.Context, *Client, map[string][]int32)
@@ -1736,7 +1737,7 @@ func HeartbeatInterval(interval time.Duration) GroupOpt {
 // Deprecated: RequireStable is now permanently enabled for all group
 // consumers. This function is a no-op.
 func RequireStableFetchOffsets() GroupOpt {
-	return groupOpt{func(cfg *cfg) {}}
+	return groupOpt{func(*cfg) {}}
 }
 
 // BlockRebalanceOnPoll switches the client to block rebalances whenever you

pkg/kgo/helpers_test.go

@@ -275,6 +275,8 @@ func testLogger() Logger {
 // (e.g. "OUT_OF_ORDER_SEQUENCE_NUMBER"). When a match is found, the entire
 // backlog is dumped first, then the triggering message, so the output shows
 // full context leading up to the event.
+var _ = newRingLogger(nil, 0).flush
+
 type ringLogEntry struct {
 	level   LogLevel
 	msg     string
@@ -294,7 +296,7 @@ func newRingLogger(real Logger, size int) *ringLogger {
 	return &ringLogger{buf: make([]ringLogEntry, size), size: size, real: real}
 }
 
-func (r *ringLogger) Level() LogLevel { return LogLevelDebug }
+func (*ringLogger) Level() LogLevel { return LogLevelDebug }
 
 func (r *ringLogger) Log(level LogLevel, msg string, keyvals ...any) {
 	r.mu.Lock()
@@ -321,7 +323,7 @@ func (r *ringLogger) Log(level LogLevel, msg string, keyvals ...any) {
 	}
 }
 
-func (r *ringLogger) shouldFlush(msg string, keyvals []any) bool {
+func (*ringLogger) shouldFlush(msg string, keyvals []any) bool {
 	// Add needle strings here to auto-flush on specific log patterns.
 	// Check both msg and keyvals, since error text can appear in either
 	// depending on the code path.
@@ -381,15 +383,15 @@ type chaosConn struct {
 
 func (c *chaosConn) Read(p []byte) (int, error) {
 	if time.Now().After(c.deadline) {
-		c.once.Do(func() { c.Conn.Close() })
+		c.once.Do(func() { c.Close() })
 		return 0, net.ErrClosed
 	}
 	return c.Conn.Read(p)
 }
 
 func (c *chaosConn) Write(p []byte) (int, error) {
 	if time.Now().After(c.deadline) {
-		c.once.Do(func() { c.Conn.Close() })
+		c.once.Do(func() { c.Close() })
 		return 0, net.ErrClosed
 	}
 	return c.Conn.Write(p)