Merge pull request #151 from xmanu/fix-strong-ref-cycle

Nathan Fallet · web-flow · commit 9fa582f4b36c · 2024-09-11T19:47:27.000+07:00
diff --git a/Sources/CodeScanner/ScannerViewController.swift b/Sources/CodeScanner/ScannerViewController.swift
@@ -448,7 +448,8 @@ extension CodeScannerView.ScannerViewController: AVCaptureMetadataOutputObjectsD
             return
         }
 
-        handler = { [self] image in
+        handler = { [weak self] image in
+            guard let self else { return }
             let result = ScanResult(string: stringValue, type: readableObject.type, image: image, corners: readableObject.corners)
 
             switch parentView.scanMode {

Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,8 @@ extension CodeScannerView.ScannerViewController: AVCaptureMetadataOutputObjectsD`
`448`	`448`	`return`
`449`	`449`	`}`
`450`	`450`
`451`		`- handler = { [self] image in`
	`451`	`+ handler = { [weak self] image in`
	`452`	`+ guard let self else { return }`
`452`	`453`	`let result = ScanResult(string: stringValue, type: readableObject.type, image: image, corners: readableObject.corners)`
`453`	`454`
`454`	`455`	`switch parentView.scanMode {`