Skip to content

Commit 419a289

Browse files
authored
Merge pull request #102 from erikfuego/security-context-missing-fields
Add missing fields for Security context and secrets
2 parents d74c33a + ed0a778 commit 419a289

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

templates/cronjob.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ spec:
3838
priorityClassName: "{{ .Values.priorityClassName }}"
3939
{{- end }}
4040
{{- if .Values.securityContext.enabled }}
41-
securityContext:
42-
fsGroup: {{ .Values.securityContext.fsGroup }}
43-
runAsUser: {{ .Values.securityContext.runAsUser }}
41+
securityContext: {{ omit .Values.securityContext "enabled" | toYaml | nindent 12 }}
4442
{{- end }}
4543
containers:
4644
- name: {{ .Chart.Name }}
@@ -52,6 +50,9 @@ spec:
5250
- --delete-untagged={{ .Values.garbageCollect.deleteUntagged }}
5351
- /etc/docker/registry/config.yml
5452
env: {{ include "docker-registry.envs" . | nindent 16 }}
53+
{{- if .Values.containerSecurityContext.enabled }}
54+
securityContext: {{ omit .Values.containerSecurityContext "enabled" | toYaml | nindent 16 }}
55+
{{- end }}
5556
volumeMounts: {{ include "docker-registry.volumeMounts" . | nindent 16 }}
5657
restartPolicy: OnFailure
5758
{{- if .Values.nodeSelector }}

templates/deployment.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ spec:
4343
priorityClassName: "{{ .Values.priorityClassName }}"
4444
{{- end }}
4545
{{- if .Values.securityContext.enabled }}
46-
securityContext:
47-
fsGroup: {{ .Values.securityContext.fsGroup }}
48-
runAsUser: {{ .Values.securityContext.runAsUser }}
46+
securityContext: {{ omit .Values.securityContext "enabled" | toYaml | nindent 8 }}
4947
{{- end }}
5048
{{- with .Values.initContainers }}
5149
initContainers:
@@ -82,6 +80,9 @@ spec:
8280
port: 5000
8381
resources: {{ toYaml .Values.resources | nindent 12 }}
8482
env: {{ include "docker-registry.envs" . | nindent 12 }}
83+
{{- if .Values.containerSecurityContext.enabled }}
84+
securityContext: {{ omit .Values.containerSecurityContext "enabled" | toYaml | nindent 12 }}
85+
{{- end }}
8586
volumeMounts: {{ include "docker-registry.volumeMounts" . | nindent 12 }}
8687
{{- if .Values.nodeSelector }}
8788
nodeSelector: {{ toYaml .Values.nodeSelector | nindent 8 }}

values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,9 @@ configData:
152152
interval: 10s
153153
threshold: 3
154154

155+
containerSecurityContext:
156+
enabled: false
157+
155158
securityContext:
156159
enabled: true
157160
runAsUser: 1000

0 commit comments

Comments
 (0)