fix: connection editor form values and config display (#288)

- Align S3 config key from force_path_style to use_path_style so the
  toggle reflects the actual stored value
- Strip runtime-injected keys (elicitation, progress_enabled) from
  connection config API responses so only user-configured values appear
- Fall back to config.description for file-only connections where
  description lives inside the config map
- Fix dirty tracking to use the same fallback
- Add Default Schema field to Trino connection editor form

Author: cjimti

pkg/admin/connection_handler.go

@@ -371,8 +371,15 @@ var connectionSensitiveKeys = []string{
 	"token", "access_token", "refresh_token", "api_key",
 }
 
+// platformInternalKeys lists config keys injected by the platform at runtime
+// (e.g., elicitation, progress) that should not be exposed in admin API responses.
+var platformInternalKeys = []string{
+	"elicitation", "progress_enabled",
+}
+
 // redactConnectionConfig returns a copy of config with sensitive fields replaced
-// by "[REDACTED]". Non-sensitive fields are copied as-is.
+// by "[REDACTED]" and platform-internal keys removed. Non-sensitive fields are
+// copied as-is.
 func redactConnectionConfig(config map[string]any) map[string]any {
 	if config == nil {
 		return nil
@@ -384,6 +391,9 @@ func redactConnectionConfig(config map[string]any) map[string]any {
 			result[key] = redactedValue
 		}
 	}
+	for _, key := range platformInternalKeys {
+		delete(result, key)
+	}
 	return result
 }
 

pkg/admin/connection_handler_test.go

@@ -508,6 +508,21 @@ func TestRedactConnectionConfig(t *testing.T) {
 		_ = redactConnectionConfig(config)
 		assert.Equal(t, "secret", config["password"])
 	})
+
+	t.Run("removes platform-internal keys", func(t *testing.T) {
+		config := map[string]any{
+			"host":             "trino.local",
+			"elicitation":      map[string]any{"enabled": true},
+			"progress_enabled": true,
+		}
+
+		redacted := redactConnectionConfig(config)
+		assert.Equal(t, "trino.local", redacted["host"])
+		_, hasElicitation := redacted["elicitation"]
+		assert.False(t, hasElicitation, "elicitation should be removed")
+		_, hasProgress := redacted["progress_enabled"]
+		assert.False(t, hasProgress, "progress_enabled should be removed")
+	})
 }
 
 func TestMergeRedactedFields(t *testing.T) {

ui/src/pages/settings/ConnectionsPanel.tsx

@@ -430,7 +430,9 @@ function ConnectionEditor({ connection, onSave, onCancel, onDirtyChange }: Edito
   const setMutation = useSetConnectionInstance();
   const [kind, setKind] = useState(connection?.kind ?? "trino");
   const [name, setName] = useState(connection?.name ?? "");
-  const [description, setDescription] = useState(connection?.description ?? "");
+  const [description, setDescription] = useState(
+    connection?.description || (connection?.config?.description as string) || "",
+  );
   const [configObj, setConfigObj] = useState<Record<string, any>>(
     connection?.config ? { ...connection.config } : {},
   );
@@ -443,9 +445,10 @@ function ConnectionEditor({ connection, onSave, onCancel, onDirtyChange }: Edito
     if (isCreate) {
       onDirtyChange(!!name.trim());
     } else {
+      const origDesc = connection?.description || (connection?.config?.description as string) || "";
       const origJson = JSON.stringify(connection?.config ?? {});
       onDirtyChange(
-        description !== (connection?.description ?? "") || configJson !== origJson,
+        description !== origDesc || configJson !== origJson,
       );
     }
   }, [kind, name, description, configJson, connection, isCreate, onDirtyChange]);
@@ -745,14 +748,24 @@ function TrinoConfigForm({ config, onChange }: ConfigFormProps) {
           help="Leave blank to keep existing password"
         />
       </div>
-      <ConfigField
-        label="Default Catalog"
-        value={String(config.catalog ?? "")}
-        onChange={(v) => onChange(update(config, "catalog", v))}
-        placeholder="iceberg"
-        mono
-        help="Default Trino catalog for queries (e.g. iceberg, hive, memory)"
-      />
+      <div className="grid grid-cols-2 gap-4">
+        <ConfigField
+          label="Default Catalog"
+          value={String(config.catalog ?? "")}
+          onChange={(v) => onChange(update(config, "catalog", v))}
+          placeholder="iceberg"
+          mono
+          help="Default Trino catalog for queries (e.g. iceberg, hive, memory)"
+        />
+        <ConfigField
+          label="Default Schema"
+          value={String(config.schema ?? "")}
+          onChange={(v) => onChange(update(config, "schema", v))}
+          placeholder="public"
+          mono
+          help="Default Trino schema within the catalog"
+        />
+      </div>
       <ConfigToggle
         label="SSL / TLS"
         checked={!!config.ssl}
@@ -836,8 +849,8 @@ function S3ConfigForm({ config, onChange }: ConfigFormProps) {
       </div>
       <ConfigToggle
         label="Force Path Style"
-        checked={!!config.force_path_style}
-        onChange={(v) => onChange(update(config, "force_path_style", v))}
+        checked={!!config.use_path_style}
+        onChange={(v) => onChange(update(config, "use_path_style", v))}
         help="Use path-style URLs (bucket in path, not subdomain). Required for MinIO and most S3-compatible stores."
       />
       <div className="border-t pt-4 mt-2">