fix: align glossaryTerms and institutionalMemory aspects with DataHub PDL schemas (#60)

- Add required auditStamp field to glossaryTermsAspect (GlossaryTerms.pdl)
- Fix linkElement JSON tag from "created" to "createStamp" (InstitutionalMemoryMetadata.pdl)
- Use time.Now().UnixMilli() for audit stamps instead of hardcoded 0
- Add newAuditStamp() helper for consistent stamp creation

Fixes #59

Author: cjimti

pkg/client/write.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"time"
 )
 
 // entityTypeFromURN derives the DataHub entity type string from a parsed URN.
@@ -169,8 +170,10 @@ func (c *Client) readGlobalTags(ctx context.Context, urn string) (*globalTagsAsp
 }
 
 // glossaryTermsAspect represents the glossaryTerms aspect structure.
+// Per GlossaryTerms.pdl, auditStamp is a required field.
 type glossaryTermsAspect struct {
-	Terms []termAssociation `json:"terms"`
+	Terms      []termAssociation `json:"terms"`
+	AuditStamp auditStampRaw     `json:"auditStamp"`
 }
 
 // termAssociation represents a glossary term association.
@@ -198,6 +201,7 @@ func (c *Client) AddGlossaryTerm(ctx context.Context, urn, termURN string) error
 	}
 
 	terms.Terms = append(terms.Terms, termAssociation{URN: termURN})
+	terms.AuditStamp = newAuditStamp()
 
 	return c.postIngestProposal(ctx, ingestProposal{
 		EntityType: entityType,
@@ -226,6 +230,7 @@ func (c *Client) RemoveGlossaryTerm(ctx context.Context, urn, termURN string) er
 		}
 	}
 	terms.Terms = filtered
+	terms.AuditStamp = newAuditStamp()
 
 	return c.postIngestProposal(ctx, ingestProposal{
 		EntityType: entityType,
@@ -258,18 +263,28 @@ type institutionalMemoryAspect struct {
 }
 
 // linkElement represents a link in the institutionalMemory aspect.
+// Per InstitutionalMemoryMetadata.pdl, the audit stamp field is "createStamp".
 type linkElement struct {
 	URL         string        `json:"url"`
 	Description string        `json:"description"`
-	Created     auditStampRaw `json:"created"`
+	CreateStamp auditStampRaw `json:"createStamp"`
 }
 
 // auditStampRaw represents an audit stamp with millisecond timestamp.
+// Per AuditStamp.pdl: time (epoch ms) and actor (entity URN) are required.
 type auditStampRaw struct {
 	Time  int64  `json:"time"`
 	Actor string `json:"actor"`
 }
 
+// newAuditStamp creates an audit stamp with the current time.
+func newAuditStamp() auditStampRaw {
+	return auditStampRaw{
+		Time:  time.Now().UnixMilli(),
+		Actor: "urn:li:corpuser:datahub",
+	}
+}
+
 // AddLink adds a link to an entity using read-modify-write on institutionalMemory.
 func (c *Client) AddLink(ctx context.Context, urn, linkURL, description string) error {
 	entityType, err := entityTypeFromURN(urn)
@@ -292,10 +307,7 @@ func (c *Client) AddLink(ctx context.Context, urn, linkURL, description string)
 	memory.Elements = append(memory.Elements, linkElement{
 		URL:         linkURL,
 		Description: description,
-		Created: auditStampRaw{
-			Time:  0, // DataHub will fill this in
-			Actor: "urn:li:corpuser:datahub",
-		},
+		CreateStamp: newAuditStamp(),
 	})
 
 	return c.postIngestProposal(ctx, ingestProposal{

pkg/client/write_test.go

@@ -325,7 +325,7 @@ func TestAddGlossaryTerm(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if r.Method == http.MethodGet {
 			resp := aspectResponse{
-				Value: json.RawMessage(`{"terms":[{"urn":"urn:li:glossaryTerm:existing"}]}`),
+				Value: json.RawMessage(`{"terms":[{"urn":"urn:li:glossaryTerm:existing"}],"auditStamp":{"time":1000,"actor":"urn:li:corpuser:admin"}}`),
 			}
 			w.Header().Set("Content-Type", "application/json")
 			_ = json.NewEncoder(w).Encode(resp)
@@ -342,6 +342,13 @@ func TestAddGlossaryTerm(t *testing.T) {
 		if proposal["aspectName"] != "glossaryTerms" {
 			t.Errorf("expected aspect 'glossaryTerms', got %v", proposal["aspectName"])
 		}
+		// Per GlossaryTerms.pdl, auditStamp is required and must have valid time
+		if terms.AuditStamp.Time <= 0 {
+			t.Error("expected auditStamp.time > 0")
+		}
+		if terms.AuditStamp.Actor == "" {
+			t.Error("expected auditStamp.actor to be non-empty")
+		}
 		w.WriteHeader(http.StatusOK)
 	}))
 	defer server.Close()
@@ -365,7 +372,7 @@ func TestAddGlossaryTerm_Duplicate(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if r.Method == http.MethodGet {
 			resp := aspectResponse{
-				Value: json.RawMessage(`{"terms":[{"urn":"urn:li:glossaryTerm:existing"}]}`),
+				Value: json.RawMessage(`{"terms":[{"urn":"urn:li:glossaryTerm:existing"}],"auditStamp":{"time":1000,"actor":"urn:li:corpuser:admin"}}`),
 			}
 			w.Header().Set("Content-Type", "application/json")
 			_ = json.NewEncoder(w).Encode(resp)
@@ -394,8 +401,11 @@ func TestAddGlossaryTerm_Duplicate(t *testing.T) {
 func TestRemoveGlossaryTerm(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if r.Method == http.MethodGet {
+			termsJSON := `{"terms":[{"urn":"urn:li:glossaryTerm:keep"},` +
+				`{"urn":"urn:li:glossaryTerm:remove"}],` +
+				`"auditStamp":{"time":1000,"actor":"urn:li:corpuser:admin"}}`
 			resp := aspectResponse{
-				Value: json.RawMessage(`{"terms":[{"urn":"urn:li:glossaryTerm:keep"},{"urn":"urn:li:glossaryTerm:remove"}]}`),
+				Value: json.RawMessage(termsJSON),
 			}
 			w.Header().Set("Content-Type", "application/json")
 			_ = json.NewEncoder(w).Encode(resp)
@@ -409,6 +419,9 @@ func TestRemoveGlossaryTerm(t *testing.T) {
 		if len(terms.Terms) != 1 {
 			t.Errorf("expected 1 term after removal, got %d", len(terms.Terms))
 		}
+		if terms.AuditStamp.Time <= 0 {
+			t.Error("expected auditStamp.time > 0 on write")
+		}
 		w.WriteHeader(http.StatusOK)
 	}))
 	defer server.Close()
@@ -433,7 +446,7 @@ func TestAddLink(t *testing.T) {
 		if r.Method == http.MethodGet {
 			linkJSON := `{"elements":[{"url":"https://existing.com",` +
 				`"description":"existing",` +
-				`"created":{"time":0,"actor":"urn:li:corpuser:datahub"}}]}`
+				`"createStamp":{"time":1000,"actor":"urn:li:corpuser:datahub"}}]}`
 			resp := aspectResponse{
 				Value: json.RawMessage(linkJSON),
 			}
@@ -452,6 +465,14 @@ func TestAddLink(t *testing.T) {
 		if len(memory.Elements) != 2 {
 			t.Errorf("expected 2 links, got %d", len(memory.Elements))
 		}
+		// New link should have a real timestamp (not 0)
+		newLink := memory.Elements[1]
+		if newLink.CreateStamp.Time <= 0 {
+			t.Error("expected createStamp.time > 0 for new link")
+		}
+		if newLink.CreateStamp.Actor != "urn:li:corpuser:datahub" {
+			t.Errorf("expected actor 'urn:li:corpuser:datahub', got %q", newLink.CreateStamp.Actor)
+		}
 		w.WriteHeader(http.StatusOK)
 	}))
 	defer server.Close()
@@ -476,7 +497,7 @@ func TestAddLink_Duplicate(t *testing.T) {
 		if r.Method == http.MethodGet {
 			linkJSON := `{"elements":[{"url":"https://existing.com",` +
 				`"description":"existing",` +
-				`"created":{"time":0,"actor":"urn:li:corpuser:datahub"}}]}`
+				`"createStamp":{"time":0,"actor":"urn:li:corpuser:datahub"}}]}`
 			resp := aspectResponse{
 				Value: json.RawMessage(linkJSON),
 			}
@@ -509,9 +530,9 @@ func TestRemoveLink(t *testing.T) {
 		if r.Method == http.MethodGet {
 			linkJSON := `{"elements":[` +
 				`{"url":"https://keep.com","description":"keep",` +
-				`"created":{"time":0,"actor":"urn:li:corpuser:datahub"}},` +
+				`"createStamp":{"time":0,"actor":"urn:li:corpuser:datahub"}},` +
 				`{"url":"https://remove.com","description":"remove",` +
-				`"created":{"time":0,"actor":"urn:li:corpuser:datahub"}}]}`
+				`"createStamp":{"time":0,"actor":"urn:li:corpuser:datahub"}}]}`
 			resp := aspectResponse{
 				Value: json.RawMessage(linkJSON),
 			}
@@ -815,6 +836,9 @@ func TestAddGlossaryTerm_NoExistingTerms(t *testing.T) {
 		if len(terms.Terms) != 1 {
 			t.Errorf("expected 1 term, got %d", len(terms.Terms))
 		}
+		if terms.AuditStamp.Time <= 0 {
+			t.Error("expected auditStamp.time > 0")
+		}
 		w.WriteHeader(http.StatusOK)
 	}))
 	defer server.Close()