Skip to content

Commit fe9a942

Browse files
committed
Stop shell=true for uf2conv
1 parent 8c2009e commit fe9a942

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build_platform.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,14 +299,14 @@ def generate_uf2(platform, fqbn, example_path):
299299
family_id = ALL_PLATFORMS[platform][1]
300300
cmd = ['python3', 'uf2conv.py', hex_input_file, '-c', '-f', family_id, '-o', output_file]
301301
else:
302-
ColorPrint.print_info(subprocess.check_output(["tree"]).decode("utf-8"))
302+
# ColorPrint.print_info(subprocess.check_output(["tree"]).decode("utf-8"))
303303
cli_build_path = "build/*.*." + fqbn.split(':')[2] + "/*.ino.bin"
304304
input_file = glob1(os.path.join(example_path, cli_build_path))
305305
output_file = os.path.splitext(input_file)[0] + ".uf2"
306306
family_id = ALL_PLATFORMS[platform][1]
307307
cmd = ['python3', 'uf2conv.py', input_file, '-c', '-f', family_id, '-b', "0x0000", '-o', output_file]
308308

309-
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
309+
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
310310
if BUILD_TIMEOUT:
311311
r = proc.wait(timeout=popen_timeout)
312312
else:

0 commit comments

Comments
 (0)