Skip to content

Commit a6b8074

Browse files
Read from read loop remove generator logic (espressif#228)
* change how read from serial is implemented * update raw read to use readloop * rm while loop on rawRead * Recoverable read errors (espressif#230) * New types for stopbits and databits * readLoop retries on recoverable errors instead of failing * fix serialoptions interface * fix lint --------- Co-authored-by: Mitch Bradley <wmb@firmworks.com>
1 parent 3dba255 commit a6b8074

File tree

6 files changed

+239
-385
lines changed

6 files changed

+239
-385
lines changed

examples/typescript/src/index.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -426,18 +426,14 @@ async function startConsoleReading() {
426426
if (isConsoleClosed || !transport) return;
427427

428428
try {
429-
const readLoop = transport.rawRead();
430-
431429
while (true && !isConsoleClosed) {
432-
const { value, done } = await readLoop.next();
430+
const value = await transport.rawRead();
433431

434-
if (done || !value) {
432+
if (!value || value.length === 0) {
435433
break;
436434
}
437435

438-
if (value) {
439-
term.write(value);
440-
}
436+
term.write(value);
441437
}
442438
} catch (error) {
443439
if (!isConsoleClosed) {

0 commit comments

Comments
 (0)