fix user supplied attributes (#388)

Author: tylerturdenpants

addon/components/attach-popover.js

@@ -262,7 +262,8 @@ export default class AttachPopover extends Component {
     super.didReceiveAttrs(...arguments);
 
     stripInProduction(() => {
-      const attrs = this.attributes || {};
+      // eslint-disable-next-line ember/no-attrs-in-components
+      const attrs = this.attrs || {};
       const userDefaults = this._config;
 
       let arrow;
@@ -312,7 +313,8 @@ export default class AttachPopover extends Component {
       return;
     }
 
-    const attrs = this.attributes || {};
+    // eslint-disable-next-line ember/no-attrs-in-components
+    const attrs = this.attrs || {};
 
     for (const key in userDefaults) {
       stripInProduction(() => {

tests/integration/components/ember-attacher/ember-attacher-test.js

@@ -25,6 +25,34 @@ module('Integration | Component | ember attacher', function(hooks) {
     assert.ok(attachment.innerHTML.includes('popper text'));
   });
 
+  test('uses the user-supplied popover class over global config class', async function(assert) {
+    this.owner.resolveRegistration('config:environment').emberAttacher = {
+      class: 'different-default'
+    };
+
+    await render(hbs`
+      <div id="target">
+        {{#attach-popover id='attachment' class='some-class some-other-class'}}
+          tooltip text
+        {{/attach-popover}}
+      </div>
+    `);
+
+    const popover = find('#attachment > .some-class');
+
+    assert.contains(
+      popover.className.split(' '),
+      [
+        'ember-attacher-fill',
+        'some-class',
+        'some-other-class',
+        'ember-attacher-hide',
+        'ember-attacher-without-arrow'
+      ],
+      'it adds the user-supplied default classes'
+    );
+  });
+
   test('uses the user-supplied default popover class - separate config', async function(assert) {
     assert.expect(1);