Merge pull request #903 from typed-ember/nvp/failing-test

@glint/template: Fix Element extends comparison

Author: NullVoxPopuli

bin/build-augmentations.mjs

@@ -33,6 +33,8 @@ traverse(ast, {
 
 let augmentations = [];
 for (const element of elements) {
+  if (element === 'HTMLElement') continue;
+
   augmentations.push(`
   interface ${element} {
     [GlintSymbol]: '${element}';

packages/template/-private/dsl/lib.dom.augmentation.d.ts

@@ -11,11 +11,6 @@ declare global {
   }
 
 
-  interface HTMLElement {
-    [GlintSymbol]: 'HTMLElement';
-  }
-
-
   interface HTMLAreaElement {
     [GlintSymbol]: 'HTMLAreaElement';
   }

packages/template/__tests__/keywords/component.test.ts

@@ -5,6 +5,16 @@ import TestComponent from '../test-component';
 
 const componentKeyword = resolve({} as ComponentKeyword);
 
+class WithElement extends TestComponent<{
+  Element: HTMLElement;
+}> {}
+
+// https://www.typescriptlang.org/play/?#code/JYWwDg9gTgLgBAbzgUwB5mQYxgFQJ4YDyAZnAL5zFQQhwDkaG2AtDAcnQNwBQ3jWudiQA8ACRwBZADIBRADbIQyAHYwAfAAoAlADoYEGahgqAJmMlSAIsABu8xSvXae-bPiLFz063YVLVmrr6hsbKZuLS9v5OWpxAA
+expectTypeOf<HTMLDivElement>().toExtend<HTMLElement>();
+
+const ElementType = emitComponent(resolve(WithElement)()).element;
+expectTypeOf<HTMLDivElement>().toExtend<typeof ElementType>();
+
 class StringComponent extends TestComponent<{
   Args: { value: string };
   Blocks: { default: [string] };

packages/template/package.json

@@ -26,7 +26,7 @@
   ],
   "devDependencies": {
     "@glimmer/component": "^1.1.2",
-    "expect-type": "^0.15.0",
+    "expect-type": "^1.2.1",
     "sums-up": "^2.1.0",
     "ember-source": "^6.2.0",
     "typescript": ">=5.6.0",